fix: GitHub token must be base64 encoded

Author: ytausch

conda_forge_tick/git_utils.py

@@ -1,5 +1,6 @@
 """Utilities for managing github repos"""
 
+import base64
 import copy
 import enum
 import logging
@@ -311,7 +312,7 @@ def add_token(self, git_dir: Path, origin: str, token: str):
         """
         Configures git with a local configuration to use the given token for the given origin.
         Internally, this sets the `http.<origin>/.extraheader` git configuration key to
-        `AUTHORIZATION: basic <token>`.
+        `AUTHORIZATION: basic <base64-encoded HTTP basic token>`.
         This is similar to how the GitHub Checkout action does it:
         https://github.com/actions/checkout/blob/eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871/adrs/0153-checkout-v2.md#PAT
 
@@ -320,12 +321,14 @@ def add_token(self, git_dir: Path, origin: str, token: str):
         :param origin: The origin to use the token for. Origin is SCHEME://HOST[:PORT] (without trailing slash).
         :param token: The token to use.
         """
+        http_basic_token = base64.b64encode(f"x-access-token:{token}".encode()).decode()
+
         self._run_git_command(
             [
                 "config",
                 "--local",
                 f"http.{origin}/.extraheader",
-                f"AUTHORIZATION: basic {token}",
+                f"AUTHORIZATION: basic {http_basic_token}",
             ],
             git_dir,
             suppress_all_output=True,

tests/test_git_utils.py

@@ -1,3 +1,4 @@
+import base64
 import datetime
 import json
 import logging
@@ -549,12 +550,14 @@ def test_git_cli_add_token_mock(run_git_command_mock: MagicMock):
 
     cli.add_token(git_dir, origin, token)
 
+    http_basic_token = base64.b64encode(f"x-access-token:{token}".encode()).decode()
+
     run_git_command_mock.assert_called_once_with(
         [
             "config",
             "--local",
             "http.https://git-repository.com/.extraheader",
-            "AUTHORIZATION: basic TOKEN",
+            f"AUTHORIZATION: basic {http_basic_token}",
         ],
         git_dir,
         suppress_all_output=True,