refactor: use monkeypatch.setenv everywhere

Author: ytausch

tests_integration/test_integration.py

@@ -37,30 +37,32 @@
 
 
 @pytest.fixture(scope="module", autouse=True)
-def global_environment_setup():
+def global_environment_setup(monkeypatch):
     """
     Set up the global environment variables for the tests.
     """
     # Make sure to also set BOT_TOKEN, we cannot validate this here!
     assert os.environ.get("TEST_SETUP_TOKEN"), "TEST_SETUP_TOKEN must be set."
 
     # In Python 3.13, this might break. https://stackoverflow.com/a/79124282
-    os.environ["MITMPROXY_CONFDIR"] = str(MITMPROXY_CONFDIR.resolve())
-    os.environ["SSL_CERT_FILE"] = str(MITMPROXY_CERT_BUNDLE_FILE.resolve())
-    os.environ["REQUESTS_CA_BUNDLE"] = str(MITMPROXY_CERT_BUNDLE_FILE.resolve())
-    os.environ["GIT_SSL_CAINFO"] = str(MITMPROXY_CERT_BUNDLE_FILE.resolve())
+    monkeypatch.setenv("MITMPROXY_CONFDIR", str(MITMPROXY_CONFDIR.resolve()))
+    monkeypatch.setenv("SSL_CERT_FILE", str(MITMPROXY_CERT_BUNDLE_FILE.resolve()))
+    monkeypatch.setenv("REQUESTS_CA_BUNDLE", str(MITMPROXY_CERT_BUNDLE_FILE.resolve()))
+    monkeypatch.setenv("GIT_SSL_CAINFO", str(MITMPROXY_CERT_BUNDLE_FILE.resolve()))
 
     github_run_id = os.environ.get("GITHUB_RUN_ID", "GITHUB_RUN_ID_NOT_SET")
-    os.environ["RUN_URL"] = (
-        f"https://github.com/regro/cf-scripts/actions/runs/{github_run_id}"
+    monkeypatch.setenv(
+        "RUN_URL", f"https://github.com/regro/cf-scripts/actions/runs/{github_run_id}"
     )
 
     # by default, we enable container mode because it is the default in the bot
-    os.environ["CF_FEEDSTOCK_OPS_IN_CONTAINER"] = "false"
+    monkeypatch.setenv("CF_FEEDSTOCK_OPS_IN_CONTAINER", "false")
 
-    # set if not set
-    os.environ.setdefault("CF_FEEDSTOCK_OPS_CONTAINER_NAME", "conda-forge-tick")
-    os.environ.setdefault("CF_FEEDSTOCK_OPS_CONTAINER_TAG", "test")
+    if not os.environ.get("CF_FEEDSTOCK_OPS_CONTAINER_NAME"):
+        monkeypatch.setenv("CF_FEEDSTOCK_OPS_CONTAINER_NAME", "conda-forge-tick")
+
+    if not os.environ.get("CF_FEEDSTOCK_OPS_CONTAINER_TAG"):
+        monkeypatch.setenv("CF_FEEDSTOCK_OPS_CONTAINER_TAG", "test")
 
     new_settings = settings()
 
@@ -75,14 +77,11 @@ def global_environment_setup():
 
 
 @pytest.fixture
-def disable_container_mode():
+def disable_container_mode(monkeypatch):
     """
     Disable container mode for the test.
     """
-    value_before = os.environ["CF_FEEDSTOCK_OPS_IN_CONTAINER"]
-    os.environ["CF_FEEDSTOCK_OPS_IN_CONTAINER"] = "true"
-    yield
-    os.environ["CF_FEEDSTOCK_OPS_IN_CONTAINER"] = value_before
+    monkeypatch.setenv("CF_FEEDSTOCK_OPS_IN_CONTAINER", "true")
 
 
 @pytest.fixture(scope="module")