Merge pull request #2785 from regro/revert-2782-revert-2649-fix/github_tag_version_source

Revert "Revert "Use version prefix from github URL""

Author: beckermr

conda_forge_tick/update_sources.py

@@ -553,11 +553,34 @@ def get_url(self, meta_yaml) -> Optional[str]:
 
 class Github(VersionFromFeed):
     name = "Github"
+    version_prefix = None
+
+    def set_version_prefix(self, version: str, split_url: list[str]):
+        self.version_prefix = self.get_version_prefix(version, split_url)
+        if self.version_prefix is None:
+            return
+        logger.debug(f"Found version prefix from url: {self.version_prefix}")
+        self.ver_prefix_remove = [self.version_prefix] + self.ver_prefix_remove
+
+    def get_version_prefix(self, version: str, split_url: list[str]):
+        """Returns prefix for the first split that contains version. If prefix
+        is empty - returns None."""
+        r = re.compile(rf"^(.*){version}")
+        for split in split_url:
+            match = r.match(split)
+            if match is not None:
+                if match.group(1) == "":
+                    return None
+                return match.group(1)
+
+        return None
 
     def get_url(self, meta_yaml) -> Optional[str]:
         if "github.com" not in meta_yaml["url"]:
             return None
         split_url = meta_yaml["url"].lower().split("/")
+        version = meta_yaml["version"]
+        self.set_version_prefix(version, split_url)
         package_owner = split_url[split_url.index("github.com") + 1]
         gh_package_name = split_url[split_url.index("github.com") + 2]
         return f"https://github.com/{package_owner}/{gh_package_name}/releases.atom"

tests/test_upstream_versions.py

@@ -1643,3 +1643,54 @@ def test_main(
     update_upstream_versions_mock.assert_called_once_with(
         gx, debug=debug, job=3, n_jobs=10, package="testpackage"
     )
+
+
+@pytest.mark.parametrize(
+    "url, version, version_prefix",
+    [
+        ("https://example.com/archs/1.2.3.tar.gz", "1.2.3", None),
+        # we don't want any assumptions on non github urls
+        ("https://example.com/archs/example-1.2.3.tar.gz", "1.2.3", None),
+        (
+            "https://github.com/example/example/archive/refs/tags/1.2.3.tar.gz",
+            "1.2.3",
+            None,
+        ),
+        (
+            "https://github.com/example/example/archive/refs/tags/example-1.2.3.tar.gz",
+            "1.2.3",
+            "example-",
+        ),
+        (
+            "https://github.com/llvm/llvm-project/releases/download/llvmorg-18.1.6/llvm-18.1.6.src.tar.xz",
+            "18.1.6",
+            "llvmorg-",
+        ),
+        (
+            "https://github.com/simplejson/simplejson/releases/download/1.2.3/simplejson-1.2.3.tar.gz",
+            "1.2.3",
+            None,
+        ),
+        # Test URLs without source version (if any)
+        ("https://example.com/archs/sources.tar.gz", "1.2.3", None),
+        ("https://github.com/archs/sources.tar.gz", "1.2.3", None),
+    ],
+)
+@flaky
+def test_github_version_prefix(url, version, version_prefix, tmpdir):
+    gh = Github()
+    meta_yaml = LazyJson(os.path.join(tmpdir, "cf-scripts-test.json"))
+    with meta_yaml as _meta_yaml:
+        _meta_yaml.update(
+            {
+                "version": version,
+                "url": url,
+            }
+        )
+
+    gh.get_url(meta_yaml)
+
+    if version_prefix is None:
+        assert gh.version_prefix is None
+    else:
+        assert gh.version_prefix == version_prefix