Skip to content

Commit fc33822

Browse files
committed
small fixes
1 parent b183dab commit fc33822

File tree

3 files changed

+14
-19
lines changed

3 files changed

+14
-19
lines changed

conda_forge_tick/auto_tick.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@
2727
from conda.models.version import VersionOrder
2828

2929
from conda_forge_tick.cli_context import CliContext
30-
from conda_forge_tick.deploy import deploy
3130
from conda_forge_tick.contexts import (
3231
ClonedFeedstockContext,
3332
FeedstockContext,
3433
MigratorSessionContext,
3534
)
35+
from conda_forge_tick.deploy import deploy
3636
from conda_forge_tick.feedstock_parser import BOOTSTRAP_MAPPINGS
3737
from conda_forge_tick.git_utils import (
3838
DryRunBackend,
@@ -620,7 +620,7 @@ def run(
620620
os.path.join("pr_json", f"{pr_data.id}.json"),
621621
)
622622
with pr_lazy_json as __edit_pr_lazy_json:
623-
__edit_pr_lazy_json.update(**pr_data.model_dump())
623+
__edit_pr_lazy_json.update(**pr_data.model_dump(mode="json"))
624624
else:
625625
pr_lazy_json = False
626626

conda_forge_tick/git_utils.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1037,12 +1037,13 @@ def create_pull_request(
10371037
Target Repository: {target_owner}/{target_repo}
10381038
Branches: {self.user}:{head_branch} -> {target_owner}:{base_branch}
10391039
Body:
1040-
{body}
1041-
==============================================================
10421040
"""
10431041
)
10441042
)
10451043

1044+
logger.debug(body)
1045+
logger.debug("==============================================================")
1046+
10461047
now = datetime.now()
10471048
return PullRequestData.model_validate(
10481049
{

conda_forge_tick/models/common.py

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
BeforeValidator,
1111
ConfigDict,
1212
Field,
13+
PlainSerializer,
1314
UrlConstraints,
1415
)
1516
from pydantic_core import Url
@@ -77,7 +78,7 @@ def none_to_empty_dict(value: T | None) -> T | dict[Never]:
7778
return value
7879

7980

80-
NoneIsEmptyDict = Annotated[dict[T], BeforeValidator(none_to_empty_dict)]
81+
NoneIsEmptyDict = Annotated[dict[K, V], BeforeValidator(none_to_empty_dict)]
8182
"""
8283
A generic dict type that converts `None` to an empty dict.
8384
This should not be needed if this proper data model is used in production.
@@ -151,22 +152,15 @@ def parse_rfc_2822_date(value: str) -> datetime:
151152
return email.utils.parsedate_to_datetime(value)
152153

153154

154-
RFC2822Date = Annotated[datetime, BeforeValidator(parse_rfc_2822_date)]
155-
156-
157-
def none_to_empty_dict(value: T | None) -> T | dict[Never, Never]:
158-
"""
159-
Convert `None` to an empty dictionary f, otherwise keep the value as is.
160-
"""
161-
if value is None:
162-
return {}
163-
return value
155+
def serialize_rfc_2822_date(value: datetime) -> str:
156+
return email.utils.format_datetime(value)
164157

165158

166-
NoneIsEmptyDict = Annotated[dict[K, V], BeforeValidator(none_to_empty_dict)]
167-
"""
168-
A generic dict type that converts `None` to an empty dict.
169-
"""
159+
RFC2822Date = Annotated[
160+
datetime,
161+
BeforeValidator(parse_rfc_2822_date),
162+
PlainSerializer(serialize_rfc_2822_date),
163+
]
170164

171165

172166
GitUrl = Annotated[Url, UrlConstraints(allowed_schemes=["git"])]

0 commit comments

Comments
 (0)