Skip to content

feat: enable arch migrators for v1 recipes #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wolfv wants to merge 3 commits into from
Closed

feat: enable arch migrators for v1 recipes #3019

wolfv wants to merge 3 commits into from
+19 −2

Conversation

@wolfv
Copy link
Contributor

@wolfv wolfv commented Oct 11, 2024 •
edited by ytausch
Loading

beckermr
beckermr requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to figure out which of the minimigrators that get attached to the osx-arm64 PRs we need to enable as well. The list of them is here: https://github.com/regro/cf-scripts/blob/main/conda_forge_tick/make_migrators.py#L194-L202

@codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.10%. Comparing base (621910b) to head (62d8ea1).
⚠️ Report is 3046 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/migrators/arch.py 20.00% 12 Missing ⚠️

❌ Your patch status has failed because the patch coverage (20.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3019      +/-   ##
==========================================
- Coverage   76.15%   76.10%   -0.06%     
==========================================
  Files         120      120              
  Lines       12942    12955      +13     
==========================================
+ Hits         9856     9859       +3     
- Misses       3086     3096      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wolfv wolfv mentioned this pull request Jan 8, 2025
Merged
@wolfv
Copy link
Contributor Author

wolfv commented Jan 28, 2025

Started this issue to track the work on minimigrators for v1 recipe: #3642

@isuruf isuruf mentioned this pull request Jan 13, 2026
Merged
1 task
@beckermr beckermr closed this Jan 17, 2026
@wolfv wolfv deleted the arch-migrator-v1 branch January 17, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beckermr beckermr beckermr requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wolfv @beckermr