Skip to content

Commit 36d7027

Browse files
committed
symbols: flake
1 parent 0f70142 commit 36d7027

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

pyplugins/apis/symbols.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,9 +206,10 @@ def resolve_addr(self, path: str, vaddr: int, base_addr: Optional[int] = None) -
206206
f"Resolved {vaddr:#x} using common base {base:#x} -> {offset:#x}")
207207
return offset
208208

209-
except ELFError:
209+
except ELFError as e:
210210
# Not an ELF or parse error, fall through to raw size check
211-
pass
211+
self.logger.error(
212+
f"ELF parsing failed for {resolved_path}: {e}")
212213

213214
# 3. Fallback: Raw File Size Check
214215
# If ELF parsing failed or no segments matched, check if a common base adjustment
@@ -225,8 +226,16 @@ def resolve_addr(self, path: str, vaddr: int, base_addr: Optional[int] = None) -
225226
self.logger.debug(
226227
f"Resolved {vaddr:#x} using common base {base:#x} -> raw offset {adjusted:#x}")
227228
return adjusted
228-
except Exception:
229-
pass
229+
except Exception as e:
230+
self.logger.error(
231+
f"Raw file fallback failed for {resolved_path}: {e}")
232+
233+
except Exception as e:
234+
self.logger.error(
235+
f"Unexpected error resolving addr {vaddr:#x} in {resolved_path}: {e}")
236+
pass
237+
238+
return None
230239

231240
def list_symbols(self, path: str, filter_str: Optional[str] = None) -> List[str]:
232241
"""

0 commit comments

Comments
 (0)