Merge pull request #75 from Relaticle/feat/validation-capabilities

feat: replace generic validation rules with field-type-owned validation capabilities

Author: ManukMinasyan

.github/instructions/filament.instructions.md

@@ -0,0 +1,28 @@
+---
+applyTo: "src/**/*.php"
+---
+
+# Filament v5 Namespace Conventions
+
+This package targets Filament v5. These namespaces are correct:
+
+- `Filament\Schemas\Components\Component` -- base class for layout components (Fieldset, Grid, Section, Tabs)
+- `Filament\Schemas\Components\Utilities\Get` / `Set` -- schema utilities
+- `Filament\Forms\Components\Component` -- base class for form field components
+- `Filament\Actions\` -- all actions (not `Filament\Tables\Actions\`)
+- `Filament\Support\Icons\Heroicon` -- icon enum
+
+Do NOT flag `Filament\Schemas\Components\Component` as incorrect.
+
+# Package Architecture
+
+- Custom field types live in `src/FieldTypeSystem/Definitions/`
+- Validation capabilities live in `src/Validation/Capabilities/`
+- Each capability implements `Relaticle\CustomFields\Contracts\ValidationCapability`
+- `DateConstraintValue` is a Spatie Laravel Data class -- use `::from()` for hydration, not manual construction
+
+# Data Patterns
+
+- DTOs use `Spatie\LaravelData\Data` with `#[MapName(SnakeCaseMapper::class)]`
+- Feature flags via `FeatureManager::isEnabled(CustomFieldsFeature::*)`
+- Field type configuration via `FieldSchema` fluent builder

database/factories/CustomFieldFactory.php

@@ -54,21 +54,11 @@ public function definition(): array
     /**
      * Configure the field with specific validation rules.
      *
-     * @param  array<string|array{name: string, parameters: array}>  $rules
+     * @param  array<string, mixed>  $rules
      */
     public function withValidation(array $rules): self
     {
-        return $this->state(function (array $attributes) use ($rules) {
-            $validationRules = collect($rules)->map(function ($rule) {
-                if (is_string($rule)) {
-                    return ['name' => $rule, 'parameters' => []];
-                }
-
-                return $rule;
-            })->toArray();
-
-            return ['validation_rules' => $validationRules];
-        });
+        return $this->state(fn () => ['validation_rules' => $rules]);
     }
 
     /**
@@ -180,35 +170,9 @@ public function systemDefined(): self
      */
     public function ofType(string $type): self
     {
-        $defaultValidation = match ($type) {
-            'text' => [
-                ['name' => 'string', 'parameters' => []],
-                ['name' => 'max', 'parameters' => [255]],
-            ],
-            'number' => [
-                ['name' => 'numeric', 'parameters' => []],
-            ],
-            'link' => [
-                ['name' => 'url', 'parameters' => []],
-            ],
-            'date' => [
-                ['name' => 'date', 'parameters' => []],
-            ],
-            'checkbox', 'toggle' => [
-                ['name' => 'boolean', 'parameters' => []],
-            ],
-            'select', 'radio' => [
-                ['name' => 'in', 'parameters' => ['option1', 'option2', 'option3']],
-            ],
-            'multi_select', 'checkbox_list', 'tags_input' => [
-                ['name' => 'array', 'parameters' => []],
-            ],
-            default => [],
-        };
-
         return $this->state([
             'type' => $type,
-            'validation_rules' => $defaultValidation,
+            'validation_rules' => [],
         ]);
     }
 
@@ -219,7 +183,7 @@ public function required(): self
     {
         return $this->state(function (array $attributes) {
             $validationRules = $attributes['validation_rules'] ?? [];
-            array_unshift($validationRules, ['name' => 'required', 'parameters' => []]);
+            $validationRules['required'] = true;
 
             return ['validation_rules' => $validationRules];
         });
@@ -234,11 +198,11 @@ public function withLength(?int $min = null, ?int $max = null): self
             $validationRules = $attributes['validation_rules'] ?? [];
 
             if ($min !== null) {
-                $validationRules[] = ['name' => 'min', 'parameters' => [$min]];
+                $validationRules['min_length'] = $min;
             }
 
             if ($max !== null) {
-                $validationRules[] = ['name' => 'max', 'parameters' => [$max]];
+                $validationRules['max_length'] = $max;
             }
 
             return ['validation_rules' => $validationRules];

phpstan.neon

@@ -14,10 +14,14 @@ parameters:
     ignoreErrors:
         # Ignore unused trait warnings for library traits meant to be consumed by package users
         - identifier: trait.unused
-        # Filament type stubs declare view() as expecting view-string|null
-        - identifier: argument.type
-          path: src/Filament/Integration/Components/Infolists/*
-        - identifier: argument.type
-          path: src/Filament/Integration/Components/Tables/Columns/*
+        # Filament type stubs declare view() as expecting view-string|null (CI-only, version-dependent)
+        -
+            identifier: argument.type
+            path: src/Filament/Integration/Components/Infolists/*
+            reportUnmatched: false
+        -
+            identifier: argument.type
+            path: src/Filament/Integration/Components/Tables/Columns/*
+            reportUnmatched: false
     parallel:
     		maximumNumberOfProcesses: 3

resources/lang/en/custom-fields.php

@@ -71,6 +71,7 @@
             'unique_per_entity_type_help' => 'Each value can only be assigned to one record of this entity type.',
             'validation' => [
                 'label' => 'Validation',
+                'required' => 'Required',
                 'rules' => 'Validation Rules',
                 'rule' => 'Rule',
                 'description' => 'Description',

src/Console/Commands/CleanupOrphanedValuesCommand.php

@@ -8,7 +8,7 @@
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\Relation;
 use Illuminate\Support\Facades\DB;
-use Relaticle\CustomFields\Models\CustomFieldValue;
+use Relaticle\CustomFields\CustomFields;
 
 final class CleanupOrphanedValuesCommand extends Command
 {
@@ -30,7 +30,7 @@ public function handle(): int
             $this->newLine();
         }
 
-        $table = (new CustomFieldValue)->getTable();
+        $table = CustomFields::newValueModel()->getTable();
         $entityTypes = DB::table($table)
             ->select('entity_type')
             ->distinct()