Don’t need to trigger intermediate responses

Author: robrichard

src/PatchResolver.js

@@ -46,22 +46,23 @@ PatchResolver.prototype.handleChunk = function(data) {
     this.chunkBuffer += data;
     const { newBuffer, parts } = parseMultipartHttp(this.chunkBuffer);
     this.chunkBuffer = newBuffer;
-    for (const part of parts) {
-        if (this.processedChunks === 0) {
-            this.previousResponse = part;
-            this.onResponse(this.previousResponse);
-        } else {
-            if (!(Array.isArray(part.path) && typeof part.data !== 'undefined')) {
-                throw new Error('invalid patch format ' + JSON.stringify(part, null, 2));
+    if (parts.length) {
+        parts.forEach(part => {
+            if (this.processedChunks === 0) {
+                this.previousResponse = part;
+            } else {
+                if (!(Array.isArray(part.path) && typeof part.data !== 'undefined')) {
+                    throw new Error('invalid patch format ' + JSON.stringify(part, null, 2));
+                }
+                this.previousResponse = {
+                    ...this.previousResponse,
+                    data: applyPatch(this.previousResponse.data, part.path, part.data),
+                    errors: mergeErrors(this.previousResponse.errors, part.errors),
+                };
             }
-            this.previousResponse = {
-                ...this.previousResponse,
-                data: applyPatch(this.previousResponse.data, part.path, part.data),
-                errors: mergeErrors(this.previousResponse.errors, part.errors),
-            };
-
-            this.onResponse(this.previousResponse);
-        }
-        this.processedChunks += 1;
+            this.processedChunks += 1;
+        });
+        // don't need to re-trigger every intermediate state
+        this.onResponse(this.previousResponse);
     }
 };

src/__test__/PatchResolver.spec.js

@@ -130,7 +130,6 @@ describe('PathResolver', function() {
 
         resolver.handleChunk(chunk1 + chunk2);
         expect(onResponse.mock.calls[0][0]).toMatchSnapshot();
-        expect(onResponse.mock.calls[1][0]).toMatchSnapshot();
     });
 
     it('should work when chunks are combined and split', function() {
@@ -145,7 +144,6 @@ describe('PathResolver', function() {
 
         resolver.handleChunk(chunk1 + chunk2 + chunk3a);
         expect(onResponse.mock.calls[0][0]).toMatchSnapshot();
-        expect(onResponse.mock.calls[1][0]).toMatchSnapshot();
         onResponse.mockClear();
 
         resolver.handleChunk(chunk3b);

src/__test__/__snapshots__/PatchResolver.spec.js.snap

@@ -218,33 +218,6 @@ Object {
 `;
 
 exports[`PathResolver should work when chunks are combined 1`] = `
-Object {
-  "data": Object {
-    "viewer": Object {
-      "currencies": null,
-      "user": Object {
-        "items": Object {
-          "edges": Array [
-            Object {
-              "node": Object {
-                "isFavorite": null,
-              },
-            },
-            Object {
-              "node": Object {
-                "isFavorite": null,
-              },
-            },
-          ],
-        },
-        "profile": null,
-      },
-    },
-  },
-}
-`;
-
-exports[`PathResolver should work when chunks are combined 2`] = `
 Object {
   "data": Object {
     "viewer": Object {
@@ -344,33 +317,6 @@ Object {
 `;
 
 exports[`PathResolver should work when chunks are combined and split 1`] = `
-Object {
-  "data": Object {
-    "viewer": Object {
-      "currencies": null,
-      "user": Object {
-        "items": Object {
-          "edges": Array [
-            Object {
-              "node": Object {
-                "isFavorite": null,
-              },
-            },
-            Object {
-              "node": Object {
-                "isFavorite": null,
-              },
-            },
-          ],
-        },
-        "profile": null,
-      },
-    },
-  },
-}
-`;
-
-exports[`PathResolver should work when chunks are combined and split 2`] = `
 Object {
   "data": Object {
     "viewer": Object {
@@ -406,7 +352,7 @@ Object {
 }
 `;
 
-exports[`PathResolver should work when chunks are combined and split 3`] = `
+exports[`PathResolver should work when chunks are combined and split 2`] = `
 Object {
   "data": Object {
     "viewer": Object {