Merge pull request #72 from ashfurrow/husky-setup

Sets up TSLint, precommit hooks

Author: alloy

package.json

@@ -1,14 +1,10 @@
 {
   "name": "relay-compiler-language-typescript",
   "version": "1.1.0",
-  "description": "A language plugin for Relay that adds TypeScript support, including emitting type definitions.",
+  "description":
+    "A language plugin for Relay that adds TypeScript support, including emitting type definitions.",
   "license": "MIT",
-  "keywords": [
-    "relay",
-    "graphql",
-    "react",
-    "typescript"
-  ],
+  "keywords": ["relay", "graphql", "react", "typescript"],
   "contributors": [
     {
       "name": "Kaare Hoff Skovgaard",
@@ -19,26 +15,31 @@
       "email": "[email protected]"
     }
   ],
-  "homepage": "https://github.com/relay-tools/relay-compiler-language-typescript",
+  "homepage":
+    "https://github.com/relay-tools/relay-compiler-language-typescript",
   "repository": {
     "type": "git",
-    "url": "https://github.com/relay-tools/relay-compiler-language-typescript.git"
+    "url":
+      "https://github.com/relay-tools/relay-compiler-language-typescript.git"
   },
   "bugs": {
-    "url": "https://github.com/relay-tools/relay-compiler-language-typescript/issues"
+    "url":
+      "https://github.com/relay-tools/relay-compiler-language-typescript/issues"
   },
   "main": "lib/index.js",
-  "files": [
-    "lib"
-  ],
+  "files": ["lib"],
   "scripts": {
     "prepublish": "npm run build",
     "build": "rm -rf lib && tsc",
-    "relay": "node bin/relay-compiler.js --schema test/schema.graphql --src test/ --outputDir __generated__",
+    "relay":
+      "node bin/relay-compiler.js --schema test/schema.graphql --src test/ --outputDir __generated__",
+    "lint": "tslint -c tslint.json --project tsconfig.json",
     "test": "npm run type-check && jest",
     "type-check": "tsc --noEmit --pretty",
     "prettier": "prettier --write '{src,types}/**/*.ts'",
-    "sync-fixtures": "rsync -avh --delete --stats --progress ../relay/packages/relay-compiler/language/javascript/__tests__/fixtures/flow-generator/*.graphql test/fixtures/type-generator"
+    "sync-fixtures":
+      "rsync -avh --delete --stats --progress ../relay/packages/relay-compiler/language/javascript/__tests__/fixtures/flow-generator/*.graphql test/fixtures/type-generator",
+    "precommit": "lint-staged"
   },
   "dependencies": {
     "immutable": "^3.7.6",
@@ -60,29 +61,44 @@
     "@types/node": "8.5.7",
     "@types/relay-runtime": "^1.3.1",
     "graphql": "^0.13.2",
+    "husky": "^1.1.0",
     "jest": "^22.1.4",
+    "lint-staged": "^7.3.0",
     "prettier": "^1.10.2",
-    "relay-compiler": "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/relay-compiler-1.6.1-plugin.1.tgz",
-    "relay-runtime": "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/relay-runtime-1.6.1-plugin.1.tgz",
-    "relay-test-utils": "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/relay-test-utils-1.6.1-plugin.1.tgz",
+    "relay-compiler":
+      "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/relay-compiler-1.6.1-plugin.1.tgz",
+    "relay-runtime":
+      "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/relay-runtime-1.6.1-plugin.1.tgz",
+    "relay-test-utils":
+      "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/relay-test-utils-1.6.1-plugin.1.tgz",
     "ts-jest": "^22.0.1",
+    "tslint": "^5.11.0",
+    "tslint-config-prettier": "^1.15.0",
     "typescript": "2.8.1"
   },
   "resolutions": {
-    "graphql-compiler": "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/graphql-compiler-1.6.1-plugin.1.tgz",
-    "relay-compiler": "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/relay-compiler-1.6.1-plugin.1.tgz",
-    "relay-runtime": "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/relay-runtime-1.6.1-plugin.1.tgz",
-    "relay-test-utils": "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/relay-test-utils-1.6.1-plugin.1.tgz"
+    "graphql-compiler":
+      "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/graphql-compiler-1.6.1-plugin.1.tgz",
+    "relay-compiler":
+      "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/relay-compiler-1.6.1-plugin.1.tgz",
+    "relay-runtime":
+      "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/relay-runtime-1.6.1-plugin.1.tgz",
+    "relay-test-utils":
+      "https://github.com/alloy/relay/releases/download/v1.6.1-plugin.1/relay-test-utils-1.6.1-plugin.1.tgz"
   },
   "jest": {
     "transform": {
       "^.+\\.tsx?$": "ts-jest"
     },
     "testRegex": "test/.+?-test\\.tsx?$",
-    "moduleFileExtensions": [
-      "js",
-      "ts",
-      "tsx"
+    "moduleFileExtensions": ["js", "ts", "tsx"]
+  },
+  "lint-staged": {
+    "**/*.json": ["prettier --write", "git add"],
+    "{src,types}/**/*.ts": [
+      "tslint -c tslint.json --fix",
+      "prettier --write",
+      "git add"
     ]
   }
 }

src/FindGraphQLTags.ts

@@ -1,10 +1,10 @@
-import * as ts from "typescript";
 import * as path from "path";
+import * as ts from "typescript";
 import * as util from "util";
 
 import { GraphQLTag, GraphQLTagFinder } from "relay-compiler";
-import { callbackify } from "util";
 import { isPropertyAccessOrQualifiedName } from "typescript";
+import { callbackify } from "util";
 
 interface Location {
   line: number;

src/TypeScriptGenerator.ts

@@ -1,21 +1,21 @@
-import { TypeGenerator, IRTransforms } from "relay-compiler";
+import { IRTransforms, TypeGenerator } from "relay-compiler";
 
-import * as ts from "typescript";
 import * as path from "path";
+import * as ts from "typescript";
 
 import {
-  transformScalarType,
-  transformInputType,
-  ScalarTypeMapping,
-  State
-} from "./TypeScriptTypeTransformers";
-import {
-  GraphQLNonNull,
   GraphQLEnumType,
-  GraphQLType,
+  GraphQLNamedType,
+  GraphQLNonNull,
   GraphQLScalarType,
-  GraphQLNamedType
+  GraphQLType
 } from "graphql";
+import {
+  ScalarTypeMapping,
+  State,
+  transformInputType,
+  transformScalarType
+} from "./TypeScriptTypeTransformers";
 
 // Get the types
 import * as GraphQLCompilerTypes from "graphql-compiler";
@@ -75,14 +75,8 @@ function makeProp(
   state: State,
   concreteType?: string
 ): ts.PropertySignature {
-  let {
-    key,
-    schemaName,
-    value,
-    conditional,
-    nodeType,
-    nodeSelections
-  } = selection;
+  let { value } = selection;
+  const { key, schemaName, conditional, nodeType, nodeSelections } = selection;
   if (nodeType) {
     value = transformScalarType(
       nodeType,
@@ -353,7 +347,7 @@ function createVisitor(options: TypeGeneratorOptions) {
         });
         state.generatedFragments.add(node.name);
         const refTypeName = getRefTypeName(node.name);
-        const refTypeNodes: ts.Node[] = []
+        const refTypeNodes: ts.Node[] = [];
         if (options.useSingleArtifactDirectory) {
           const _refTypeName = `_${refTypeName}`;
           const _refType = ts.createVariableStatement(
@@ -375,14 +369,14 @@ function createVisitor(options: TypeGeneratorOptions) {
             refTypeName,
             ts.createTypeQueryNode(ts.createIdentifier(_refTypeName))
           );
-          refTypeNodes.push(_refType)
-          refTypeNodes.push(refType)
+          refTypeNodes.push(_refType);
+          refTypeNodes.push(refType);
         } else {
           const refType = exportType(
             refTypeName,
             ts.createKeywordTypeNode(ts.SyntaxKind.AnyKeyword)
-          )
-          refTypeNodes.push(refType)
+          );
+          refTypeNodes.push(refType);
         }
         const baseType = selectionsToAST(selections, state, refTypeName);
         const type = isPlural(node)
@@ -452,7 +446,7 @@ function createVisitor(options: TypeGeneratorOptions) {
   };
 }
 
-function selectionsToMap(selections: Array<Selection>): SelectionMap {
+function selectionsToMap(selections: Selection[]): SelectionMap {
   const map = new Map();
   selections.forEach(selection => {
     const previousSel = map.get(selection.key);

src/TypeScriptTypeTransformers.ts

@@ -2,8 +2,8 @@ import * as ts from "typescript";
 
 import {
   GraphQLEnumType,
-  GraphQLInputType,
   GraphQLInputObjectType,
+  GraphQLInputType,
   GraphQLInterfaceType,
   GraphQLList,
   GraphQLNonNull,

src/index.ts

@@ -1,7 +1,7 @@
 import { PluginInterface } from "relay-compiler";
 
-import { formatGeneratedModule } from "./formatGeneratedModule";
 import { find } from "./FindGraphQLTags";
+import { formatGeneratedModule } from "./formatGeneratedModule";
 import * as TypeScriptGenerator from "./TypeScriptGenerator";
 
 export default function plugin(): PluginInterface {

tslint.json

@@ -0,0 +1,25 @@
+{
+  "defaultSeverity": "error",
+  "extends": ["tslint:recommended", "tslint-config-prettier"],
+  "jsRules": {},
+  "rules": {
+    "curly": false,
+    "interface-name": [true, "never-prefix"],
+    "max-classes-per-file": false,
+    "member-access": [false],
+    "no-shadowed-variable": false,
+    "member-ordering": false,
+    "forin": false,
+    "no-console": false,
+    "no-namespace": [true, "allow-declarations"],
+    "no-unused-expression": false,
+    "no-var-requires": false,
+    "object-literal-sort-keys": false,
+    "ordered-imports": true,
+    "trailing-comma": false,
+    "interface-over-type-literal": false,
+    "variable-name": [true, "ban-keywords", "allow-leading-underscore"],
+    "jsdoc-format": false
+  },
+  "rulesDirectory": []
+}