add optional to refTypeDataProperty

Author: renanmav

src/TypeScriptGenerator.ts

@@ -474,17 +474,14 @@ function createVisitor(
         );
         return nodes;
       },
-
       Fragment(node) {
         const flattenedSelections: Selection[] = flattenArray(
           /* $FlowFixMe: selections have already been transformed */
           (node.selections as any) as ReadonlyArray<ReadonlyArray<Selection>>
         );
-
         const numConcreteSelections = flattenedSelections.filter(
           s => s.concreteType
         ).length;
-
         const selections = flattenedSelections.map(selection => {
           if (
             numConcreteSelections <= 1 &&
@@ -498,16 +495,15 @@ function createVisitor(
               }
             ];
           }
-
           return [selection];
         });
-
         state.generatedFragments.add(node.name);
 
         const refTypeName = getRefTypeName(node.name);
         const refTypeDataProperty = objectTypeProperty(
           DATA_REF,
-          ts.createTypeReferenceNode(`${node.name}$data`, undefined)
+          ts.createTypeReferenceNode(`${node.name}$data`, undefined),
+          { optional: true }
         );
         refTypeDataProperty.questionToken = ts.createToken(
           ts.SyntaxKind.QuestionToken
@@ -528,21 +524,22 @@ function createVisitor(
         const dataType = ts.createTypeReferenceNode(node.name, undefined);
 
         const unmasked = node.metadata != null && node.metadata.mask === false;
-
         const baseType = selectionsToAST(
           schema,
           selections,
           state,
           unmasked,
           unmasked ? undefined : node.name
         );
-
         const type = isPlural(node)
           ? ts.createTypeReferenceNode(ts.createIdentifier("ReadonlyArray"), [
               baseType
             ])
           : baseType;
         state.runtimeImports.add("FragmentRefs");
+        if (state.hasConnectionResolver) {
+          state.runtimeImports.add("ConnectionReference");
+        }
 
         return [
           ...getEnumDefinitions(schema, state),
@@ -1085,7 +1082,7 @@ function getEnumDefinitions(
 function getRefetchableQueryParentFragmentName(
   state: State,
   metadata: Metadata
-): string | null | undefined {
+): string | null {
   if (
     (metadata && !metadata.isRefetchableQuery) ||
     (!state.useHaste && !state.useSingleArtifactDirectory)

test/TypeScriptGenerator-test.ts

@@ -9,7 +9,7 @@ import { generateTestsFromFixtures } from "relay-test-utils-internal/lib/generat
 import * as parseGraphQLText from "relay-test-utils-internal/lib/parseGraphQLText";
 import * as RelayTestSchema from "relay-test-utils-internal/lib/RelayTestSchema";
 import * as TypeScriptGenerator from "../src/TypeScriptGenerator";
-import * as Schema from 'relay-compiler/lib/core/Schema';
+import * as Schema from "relay-compiler/lib/core/Schema";
 
 const DEPRECATED__create = (Schema as any).DEPRECATED__create;
 
@@ -49,20 +49,23 @@ function generate(
     `
   ]);
   const { definitions } = parseGraphQLText(schema, text);
-  const compilerSchema = DEPRECATED__create(
-    RelayTestSchema,
-    schema,
-  );
+  const compilerSchema = DEPRECATED__create(RelayTestSchema, schema);
   return new GraphQLCompilerContext(compilerSchema)
     .addAll(definitions)
     .applyTransforms(TypeScriptGenerator.transforms)
     .documents()
     .map(
       doc =>
-        `// ${doc.name}.graphql\n${TypeScriptGenerator.generate(compilerSchema, doc as any, {
-          ...options,
-          normalizationIR: context ? (context.get(doc.name) as Root) : undefined
-        })}`
+        `// ${doc.name}.graphql\n${TypeScriptGenerator.generate(
+          compilerSchema,
+          doc as any,
+          {
+            ...options,
+            normalizationIR: context
+              ? (context.get(doc.name) as Root)
+              : undefined
+          }
+        )}`
     )
     .join("\n\n");
 }
@@ -73,11 +76,11 @@ describe("Snapshot tests", () => {
       RelayTestSchema,
       IRTransforms.schemaExtensions
     );
-    const { definitions, schema: extendedSchema } = parseGraphQLText(schema, text);
-    const compilerSchema = DEPRECATED__create(
-      RelayTestSchema,
-      extendedSchema,
+    const { definitions, schema: extendedSchema } = parseGraphQLText(
+      schema,
+      text
     );
+    const compilerSchema = DEPRECATED__create(RelayTestSchema, extendedSchema);
     return new GraphQLCompilerContext(compilerSchema)
       .addAll(definitions)
       .applyTransforms([