address feedback - phase 1

Author: 0xTxbi

packages/ui/src/components/common/MultiWalletDropdown.tsx

@@ -69,7 +69,7 @@ export const MultiWalletDropdown: FC<MultiWalletDropdownProps> = ({
       }
       return true
     })
-  }, [wallets, chain])
+  }, [wallets, chain, disableWalletFiltering])
 
   const selectedWallet = useMemo(
     () =>

packages/ui/src/components/common/SlippageToleranceConfig.tsx

@@ -26,6 +26,7 @@ import { EventNames } from '../../constants/events.js'
 import { useDebounceValue, useMediaQuery } from 'usehooks-ts'
 import useFallbackState from '../../hooks/useFallbackState.js'
 import { Modal } from './Modal.js'
+import { convertBpsToPercent } from '../../utils/numbers.js'
 
 type SlippageToleranceConfigProps = {
   open?: boolean
@@ -40,18 +41,6 @@ type SlippageToleranceConfigProps = {
   showLabel?: boolean
 }
 
-const convertBpsToPercent = (bps?: string) => {
-  if (bps === undefined) return undefined
-  const numeric = Number(bps)
-  if (!Number.isFinite(numeric)) return undefined
-
-  const percent = numeric / 100
-  if (!Number.isFinite(percent)) return undefined
-
-  const formatted = percent.toFixed(percent % 1 === 0 ? 0 : 2)
-  return formatted.replace(/\.0+$/, '').replace(/\.00$/, '')
-}
-
 type SlippageTabsProps = {
   mode: SlippageToleranceMode
   setMode: (mode: SlippageToleranceMode) => void

packages/ui/src/components/widgets/TokenWidget/widget/TokenWidgetRenderer.tsx

@@ -14,7 +14,7 @@ import {
 } from '../../../../hooks/index.js'
 import type { Address, WalletClient } from 'viem'
 import { formatUnits, parseUnits } from 'viem'
-import { normalizeTokenId } from '../../../../utils/tokens.js'
+import { normalizeTokenAddress } from '../../../../utils/tokens.js'
 import { useAccount, useWalletClient } from 'wagmi'
 import { useCapabilities } from 'wagmi/experimental'
 import type { Token } from '../../../../types/index.js'
@@ -620,10 +620,10 @@ const TokenWidgetRenderer: FC<TokenWidgetRendererProps> = ({
   }, [sponsoredTokens, relayClient?.chains])
 
   const normalizedToToken = toToken && toToken.address
-    ? normalizeTokenId(toToken.chainId, toToken.address, toChain?.vmType)
+    ? normalizeTokenAddress(toToken.chainId, toToken.address, toChain?.vmType)
     : undefined
   const normalizedFromToken = fromToken && fromToken.address
-    ? normalizeTokenId(fromToken.chainId, fromToken.address, fromChain?.vmType) 
+    ? normalizeTokenAddress(fromToken.chainId, fromToken.address, fromChain?.vmType) 
     : undefined
 
   const isGasSponsorshipEnabled =

packages/ui/src/hooks/useMultiWalletBalances.ts

@@ -3,11 +3,7 @@ import useDuneBalances, {
   type BalanceMap,
   type DuneBalanceResponse
 } from './useDuneBalances.js'
-import {
-  evmDeadAddress,
-  solDeadAddress,
-  bitcoinDeadAddress
-} from '@relayprotocol/relay-sdk'
+import { isDeadAddress } from '@relayprotocol/relay-sdk'
 
 type LinkedWallet = {
   address: string
@@ -28,9 +24,7 @@ export const useMultiWalletBalances = (
 
     if (
       primaryAddress &&
-      primaryAddress !== evmDeadAddress &&
-      primaryAddress !== solDeadAddress &&
-      primaryAddress !== bitcoinDeadAddress &&
+      !isDeadAddress(primaryAddress) &&
       isValidAddress
     ) {
       addresses.add(primaryAddress)
@@ -40,9 +34,7 @@ export const useMultiWalletBalances = (
       linkedWallets.forEach((wallet) => {
         if (
           wallet.address &&
-          wallet.address !== evmDeadAddress &&
-          wallet.address !== solDeadAddress &&
-          wallet.address !== bitcoinDeadAddress
+          !isDeadAddress(wallet.address)
         ) {
           addresses.add(wallet.address)
         }

packages/ui/src/utils/numbers.ts

@@ -330,8 +330,22 @@ function formatSignificantDigits(
   return isNegative ? '-' + result : result
 }
 
+/**
+ * Converts basis points to percentage string
+ * @param bps Basis points as string (e.g. "250" for 2.5%)
+ * @returns Formatted percentage string or undefined
+ */
+function convertBpsToPercent(bps?: string) {
+  if (bps === undefined) return undefined
+  const numeric = Number(bps)
+  if (!Number.isFinite(numeric)) return undefined
 
+  const percent = numeric / 100
+  if (!Number.isFinite(percent)) return undefined
 
+  const formatted = percent.toFixed(percent % 1 === 0 ? 0 : 2)
+  return formatted.replace(/\.0+$/, '').replace(/\.00$/, '')
+}
 
 export {
   formatDollar,
@@ -340,5 +354,6 @@ export {
   formatFixedLength,
   formatNumber,
   formatSignificantDigits,
-  truncateBalance
+  truncateBalance,
+  convertBpsToPercent
 }

packages/ui/src/utils/tokens.ts

@@ -68,9 +68,9 @@ export const tokensAreEqual = (a?: Token, b?: Token): boolean => {
 }
 
 /**
- * Normalizes token identifier for cross-chain consistency
+ * Normalizes token address for cross-chain consistency
  */
-export const normalizeTokenId = (chainId: number, address: string, vmType?: string): string => {
+export const normalizeTokenAddress = (chainId: number, address: string, vmType?: string): string => {
   const normalizedAddress = vmType === 'evm' ? address.toLowerCase() : address
   return `${chainId}:${normalizedAddress}`
 }