Correct unit test

Author: webbnh

tests/test_downstream_issue.py

@@ -292,20 +292,19 @@ def test_assign_user_multiple(self, mock_client, mock_rover_lookup):
         # Set up return values
         mock_user = MagicMock()
         mock_user.displayName = "mock_assignee"
-        mock_user.name = "mock_assignee_n"
-        mock_user.emailAddress = "wrong_mock_user@redhat.com"
+        mock_user.name = "mock_assignee_name"
+        mock_user.emailAddress = "mock_user@redhat.com"
         mock_user.key = "mock_user_key"
         mock_user2 = MagicMock()
         mock_user2.displayName = "mock_assignee2"
-        mock_user2.name = "mock_assignee2_n"
-        mock_user.emailAddress = "mock_user@redhat.com"
-        mock_user2.key = "mock_user_key2"
+        mock_user2.name = "mock_assignee2_name"
+        mock_user2.emailAddress = "wrong_mock_user@redhat.com"
+        mock_user2.key = "mock_user2_key"
         mock_client.search_assignable_users_for_issues.return_value = [
             mock_user,
             mock_user2,
         ]
         mock_client.assign_issue.return_value = True
-        mock_rover_lookup.return_value = ["mock_user@redhat.com"]
         self.mock_issue.assignee = [
             {"fullname": None, "login": "login1"},
             {"fullname": "", "login": "login2"},
@@ -314,6 +313,16 @@ def test_assign_user_multiple(self, mock_client, mock_rover_lookup):
             # Should not match this next -- should match the previous.
             {"fullname": "mock_assignee2", "login": "login5"},
         ]
+        rlu = {
+            "login1": [],
+            "login2": [],
+            "login3": ["not_a_match@redhat.com"],
+            "login4": [mock_user.emailAddress],
+            "login5": [mock_user2.emailAddress],
+        }
+        mock_rover_lookup.side_effect = lambda un: rlu.get(
+            un, AssertionError("Test bug!  Missing assignee login")
+        )
 
         # Call the assign user function
         d.assign_user(