feat: Add url validation on findFeed

Author: relekang

src/__tests__/__snapshots__/api.tests.ts.snap

@@ -334,6 +334,35 @@ exports[`
 }
 `;
 
+exports[`
+  findFeed(url: "https://non--------existing-domain.com") {
+    link
+  }
+ 1`] = `
+{
+  "data": null,
+  "errors": [
+    {
+      "extensions": {
+        "code": "dns-lookup-error",
+        "message": "Could not find domain",
+        "type": "DnsLookupError",
+      },
+      "locations": [
+        {
+          "column": 3,
+          "line": 2,
+        },
+      ],
+      "message": "Could not find domain",
+      "path": [
+        "findFeed",
+      ],
+    },
+  ],
+}
+`;
+
 exports[`
   findFeed(url: "https://rolflekang.com") {
     link
@@ -352,3 +381,32 @@ exports[`
   },
 }
 `;
+
+exports[`
+  findFeed(url: "not-a-url") {
+    link
+  }
+ 1`] = `
+{
+  "data": null,
+  "errors": [
+    {
+      "extensions": {
+        "code": "invalid-url",
+        "message": "Invalid url",
+        "type": "InvalidUrlError",
+      },
+      "locations": [
+        {
+          "column": 3,
+          "line": 2,
+        },
+      ],
+      "message": "Invalid url",
+      "path": [
+        "findFeed",
+      ],
+    },
+  ],
+}
+`;

src/__tests__/api.tests.ts

@@ -62,3 +62,15 @@ testGraphqlApi`
     items { title }
   }
 `;
+
+testGraphqlApi`
+  findFeed(url: "not-a-url") {
+    link
+  }
+`;
+
+testGraphqlApi`
+  findFeed(url: "https://non--------existing-domain.com") {
+    link
+  }
+`;

src/errors.ts

@@ -139,6 +139,14 @@ export class ConnectionFailedError extends BaseError {
 	}
 }
 
+export class InvalidUrlError extends BaseError {
+	url: string;
+	constructor(url: string) {
+		super("Invalid url", "invalid-url");
+		this.url = url;
+	}
+}
+
 export function createErrorFormatter(
 	Sentry: any,
 ): ApolloServerOptions<any>["formatError"] {

src/handlers/findFeed.ts

@@ -3,10 +3,11 @@ import type { CheerioAPI } from "cheerio";
 import type { Element, Node } from "domhandler";
 import normalizeUrl from "normalize-url";
 
-import { BaseError } from "../errors.js";
+import { BaseError, InvalidUrlError } from "../errors.js";
 import { logger } from "../logger.js";
 import request from "../request.js";
 import { parseFromQuery, parseFromString } from "./feed.js";
+import isUrl from "is-url";
 
 type FindFeedResponse = {
 	title: string;
@@ -93,6 +94,10 @@ export async function findFeed({
 	url: string;
 	normalize?: boolean;
 }): Promise<FindFeedResponse[]> {
+	if (!isUrl(url)) {
+		throw new InvalidUrlError(url);
+	}
+
 	const normalizedUrl = normalize ? url : normalizeUrl(url, normalizeOptions);
 
 	if (!normalizedUrl) {