address review comments

Author: dhalbert

extmod/modhashlib.c

@@ -114,7 +114,7 @@ STATIC mp_obj_t hashlib_sha256_digest(mp_obj_t self_in) {
 
 #else
 
-// CIRCUITPY-CHNAGE
+// CIRCUITPY-CHANGE
 static void check_not_unicode(const mp_obj_t arg) {
     #if MICROPY_CPYTHON_COMPAT
     if (mp_obj_is_str(arg)) {

frozen/Adafruit_CircuitPython_asyncio

@@ -152,7 +152,7 @@ typedef long mp_off_t;
 #define MICROPY_FATFS_RPATH            (2)
 #define MICROPY_FATFS_MAX_SS           (4096)
 #define MICROPY_FATFS_LFN_CODE_PAGE    437 /* 1=SFN/ANSI 437=LFN/U.S.(OEM) */
-// CIRCUITPY_CHANGE: enable FAT32 support
+// CIRCUITPY-CHANGE: enable FAT32 support
 #define MICROPY_FATFS_MKFS_FAT32       (1)
 // CIRCUITPY-CHANGE: allow FAT label access
 #define MICROPY_FATFS_USE_LABEL (1)

ports/unix/mpconfigport.h

@@ -80,7 +80,7 @@ static inline int fp_isless1(float x) {
 
 #elif MICROPY_FLOAT_IMPL == MICROPY_FLOAT_IMPL_DOUBLE
 
-// CIRCUITPY-CHNAGE: prevent warnings
+// CIRCUITPY-CHANGE: prevent warnings
 #pragma GCC diagnostic ignored "-Wfloat-equal"
 #define FPTYPE double
 #define FPCONST(x) x

py/formatfloat.c

@@ -134,7 +134,7 @@ NORETURN void nlr_jump(void *val) {
         "bx     lr                  \n" // return
         :                           // output operands
         : "r" (top)                 // input operands
-        // CIRCUITPY-CHANGE: MicroPython caught up with this change in https://github.com/micropython/micropython/pull/14126
+        // CIRCUITPY-CHANGE: MicroPython makes this change in https://github.com/micropython/micropython/pull/14126 (later than v1.22)
         : "memory"                  // clobbered registers
         );
 

py/nlrthumb.c

@@ -530,7 +530,7 @@ STATIC mp_obj_t int_from_bytes(size_t n_args, const mp_obj_t *pos_args, mp_map_t
 STATIC MP_DEFINE_CONST_FUN_OBJ_KW(int_from_bytes_fun_obj, 3, int_from_bytes);
 STATIC MP_DEFINE_CONST_CLASSMETHOD_OBJ(int_from_bytes_obj, MP_ROM_PTR(&int_from_bytes_fun_obj));
 
-// CIRCUITPY-CHANGE: supprts signed
+// CIRCUITPY-CHANGE: supports signed
 STATIC mp_obj_t int_to_bytes(size_t n_args, const mp_obj_t *pos_args, mp_map_t *kw_args) {
     enum { ARG_length, ARG_byteorder, ARG_signed };
     static const mp_arg_t allowed_args[] = {

py/objint.c

@@ -112,8 +112,6 @@ void qstr_pool_info(size_t *n_pool, size_t *n_qstr, size_t *n_str_data_bytes, si
 void qstr_dump_data(void);
 
 #if MICROPY_ROM_TEXT_COMPRESSION
-// CIRCUITPY-CHANGE: TODO not const previusly, should it be??
-// TEST COMPILE with const ******************
 void mp_decompress_rom_string(byte *dst, const mp_rom_error_text_t src);
 #define MP_IS_COMPRESSED_ROM_STRING(s) (*(byte *)(s) == 0xff)
 #endif

py/qstr.h

@@ -9,6 +9,4 @@
 
 #include "py/obj.h"
 
-///#include "shared-module/rainbowio/__init__.h"
-
 int32_t colorwheel(mp_float_t pos);

shared-bindings/rainbowio/__init__.h

@@ -46,8 +46,6 @@
     except sh.ErrorReturnCode_128:
         pass
 
-sys.exit(0)
-
 # We inherit stm32 changes into stm because we did a git rename.
 git.status("--porcelain=1", "ports/stm", _out=out_buf)
 out_buf.seek(0)