Use early return

xendk · xendk · commit 4104fe7b4cf5 · 2022-02-22T14:28:30.000+01:00
diff --git a/src/SecurityAlertIssue.php b/src/SecurityAlertIssue.php
@@ -98,10 +98,12 @@ public function __construct(array $data)
 
         $labels = \getenv('JIRA_ISSUE_LABELS');
 
-        if ($labels) {
-            foreach (\explode(',', $labels) as $label) {
-                $this->setKeyLabel($label);
-            }
+        if (!$labels) {
+            return;
+        }
+
+        foreach (\explode(',', $labels) as $label) {
+            $this->setKeyLabel($label);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -98,10 +98,12 @@ public function __construct(array $data)`
`98`	`98`
`99`	`99`	`$labels = \getenv('JIRA_ISSUE_LABELS');`
`100`	`100`
`101`		`- if ($labels) {`
`102`		`- foreach (\explode(',', $labels) as $label) {`
`103`		`- $this->setKeyLabel($label);`
`104`		`- }`
	`101`	`+ if (!$labels) {`
	`102`	`+ return;`
	`103`	`+ }`
	`104`	`+`
	`105`	`+ foreach (\explode(',', $labels) as $label) {`
	`106`	`+ $this->setKeyLabel($label);`
`105`	`107`	`}`
`106`	`108`	`}`
`107`	`109`