Skip to content

Commit 69ebeef

Browse files
Copilotkentcdodds
andcommitted
Update TypeScript to 5.9.3 and fix type errors
Co-authored-by: kentcdodds <[email protected]>
1 parent 4a92bbf commit 69ebeef

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

.github/workflows/validate.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
if: ${{ !contains(github.head_ref, 'all-contributors') }}
1717
strategy:
1818
matrix:
19-
node: [16, 18]
19+
node: [lts/-1, lts/*]
2020
runs-on: ubuntu-latest
2121
steps:
2222
- name: 🛑 Cancel Previous Runs
@@ -63,7 +63,7 @@ jobs:
6363
- name: ⎔ Setup node
6464
uses: actions/setup-node@v6
6565
with:
66-
node-version: 18
66+
node-version: lts/*
6767

6868
- name: 📥 Download deps
6969
uses: bahmutov/npm-install@v1

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"kcd-scripts": "^12.2.0",
4949
"remark": "^14.0.2",
5050
"remark-html": "^15.0.1",
51-
"typescript": "^4.7.4"
51+
"typescript": "^5.9.3"
5252
},
5353
"peerDependencies": {
5454
"@remark-embedder/core": "^3.0.0"

src/__tests__/index.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,14 @@ const unquoteSerializer = {
1212
expect.addSnapshotSerializer(unquoteSerializer)
1313

1414
test('smoke test', async () => {
15-
const result = await remark()
15+
const processor = remark()
1616
.use(remarkEmbedder, {
1717
transformers: [CodeSandboxTransformer],
1818
})
19+
// @ts-expect-error - Type inference issue with remark plugins
1920
.use(remarkHTML, {sanitize: false})
20-
.process(
21+
22+
const result = await processor.process(
2123
`
2224
This is a CodeSandbox:
2325

src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {Transformer} from '@remark-embedder/core'
1+
import {type Transformer} from '@remark-embedder/core'
22

33
const transformer: Transformer = {
44
getHTML: urlString => {

0 commit comments

Comments
 (0)