Skip to content

Commit 18cf12e

Browse files
authored
feat: add playwright container (#167)
## Context This PR will use the playwright container instead of installing the dependencies on the pipeline ## Changes - Added: container to workflow ## Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] I have tested my code for breaking changes and added the corresponding footer in this PR if needed - [x] I have added tests that prove my fix is effective or that my feature works
1 parent fa84ead commit 18cf12e

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

.github/workflows/playwright.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,10 @@ jobs:
2828
max_timeout: 600
2929

3030
test_e2e:
31+
name: Test e2e
3132
runs-on: ubuntu-latest
33+
container:
34+
image: mcr.microsoft.com/playwright:v1.50.0-noble
3235
needs: test_setup
3336
timeout-minutes: 60
3437
steps:
@@ -38,16 +41,14 @@ jobs:
3841
- name: Setup
3942
uses: ./.github/actions/setup
4043

41-
- name: Install Playwright browsers
42-
run: pnpm exec playwright install --with-deps
43-
4444
- name: Run tests
4545
run: pnpm test:e2e
4646
env:
4747
PLAYWRIGHT_TEST_BASE_URL: ${{ needs.test_setup.outputs.preview_url }}
48+
HOME: /root
4849

4950
- name: Upload test results
50-
if: always() && !cancelled()
51+
if: ${{ !cancelled() }}
5152
uses: actions/upload-artifact@v4
5253
with:
5354
name: playwright-test-results

0 commit comments

Comments
 (0)