Return an empty collection when where(:foo => []) is given

The previous behaviour was to return everything! This is now
consistent with ActiveRecord and avoids a needless request.

The new behaviour is not applied to has_one associations as they
currently seem to ignore the where method entirely.

Author: chewi

lib/her/model/associations/association.rb

@@ -47,9 +47,13 @@ def fetch(opts = {})
           return @parent.attributes[@name] unless @params.any? || @parent.attributes[@name].blank?
           return @opts[:default].try(:dup) if @parent.new?
 
-          path = build_association_path lambda { "#{@parent.request_path(@params)}#{@opts[:path]}" }
-          @klass.get(path, @params).tap do |result|
-            @cached_result = result unless @params.any?
+          if @params.values.include?([]) and !self.is_a?(HasOneAssociation)
+            Her::Collection.new
+          else
+            path = build_association_path lambda { "#{@parent.request_path(@params)}#{@opts[:path]}" }
+            @klass.get(path, @params).tap do |result|
+              @cached_result = result unless @params.any?
+            end
           end
         end
 

lib/her/model/relation.rb

@@ -65,10 +65,14 @@ def kind_of?(thing)
       # @private
       def fetch
         @_fetch ||= begin
-          path = @parent.build_request_path(@parent.collection_path, @params)
-          method = @parent.method_for(:find)
-          @parent.request(@params.merge(:_method => method, :_path => path)) do |parsed_data, response|
-            @parent.new_collection(parsed_data)
+          if @params.values.include?([])
+            Her::Collection.new
+          else
+            path = @parent.build_request_path(@parent.collection_path, @params)
+            method = @parent.method_for(:find)
+            @parent.request(@params.merge(:_method => method, :_path => path)) do |parsed_data, response|
+              @parent.new_collection(parsed_data)
+            end
           end
         end
       end

spec/model/associations_spec.rb

@@ -236,6 +236,13 @@
       expect { @user_without_included_data.comments.reload }.to change { @user_without_included_data.comments.first.object_id }
     end
 
+    it "returns an empty collection without fetching when [] is a parameter" do
+      Foo::Comment.should_not_receive(:request)
+      comments = @user_without_included_data.comments.where(:foo_id => [])
+      comments.should respond_to(:length)
+      comments.size.should eql 0
+    end
+
     it "maps an array of included data through has_one" do
       expect(@user_with_included_data.role).to be_a(Foo::Role)
       expect(@user_with_included_data.role.object_id).to eq(@user_with_included_data.role.object_id)

spec/model/relation_spec.rb

@@ -59,6 +59,13 @@
         expect(Foo::User.create(fullname: "George Michael Bluth").id).to eq(3)
         expect(Foo::User.all.size).to eql 3
       end
+
+      it "returns an empty collection without fetching when [] is given" do
+        Foo::User.should_not_receive(:request)
+        users = Foo::User.where(:fullname => [])
+        users.should respond_to(:length)
+        users.size.should eql 0
+      end
     end
 
     context "for parent class" do