Skip to content

Commit 249c7b0

Browse files
authored
Merge pull request #1027 from ethereum/cleanup
cleanup redundant code and console logs
2 parents 3328087 + 4c5832e commit 249c7b0

File tree

2 files changed

+5
-26
lines changed

2 files changed

+5
-26
lines changed

apps/remix-ide/src/migrateFileSystem.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ export default (fileProvider) => {
1515
fileProvider.set(path, content)
1616
// TODO https://github.com/ethereum/remix-ide/issues/2377
1717
// fileStorage.remove(path) we don't want to remove it as we are still supporting the old version
18-
console.log('file migrated', path)
1918
}
2019
})
2120
fileStorageBrowserFS.set(flag, 'done')

libs/remix-ui/workspace/src/lib/remix-ui-workspace.tsx

Lines changed: 5 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -299,12 +299,6 @@ export const Workspace = (props: WorkspaceProps) => {
299299
)
300300
}
301301

302-
// const handleWorkspaceSelect = (e) => {
303-
// const value = e.target.value
304-
305-
// setWorkspace(value)
306-
// }
307-
308302
return (
309303
<div className='remixui_container'>
310304
<ModalDialog
@@ -358,15 +352,15 @@ export const Workspace = (props: WorkspaceProps) => {
358352
title='Delete'>
359353
</span>
360354
</span>
361-
<select id="workspacesSelect" data-id="workspacesSelect" onChange={(e) => setWorkspace(e.target.value)} className="form-control custom-select">
355+
<select id="workspacesSelect" value={state.currentWorkspace} data-id="workspacesSelect" onChange={(e) => setWorkspace(e.target.value)} className="form-control custom-select">
362356
{
363357
state.workspaces
364-
.map((folder) => {
365-
return <option selected={state.currentWorkspace === folder} value={folder}>{folder}</option>
358+
.map((folder, index) => {
359+
return <option key={index} value={folder}>{folder}</option>
366360
})
367361
}
368-
<option selected={state.currentWorkspace === LOCALHOST} value={LOCALHOST}>{state.currentWorkspace === LOCALHOST ? 'localhost' : LOCALHOST}</option>
369-
{ state.workspaces.length <= 0 && <option selected={state.currentWorkspace === NO_WORKSPACE} value={NO_WORKSPACE}>{NO_WORKSPACE}</option> }
362+
<option value={LOCALHOST}>{state.currentWorkspace === LOCALHOST ? 'localhost' : LOCALHOST}</option>
363+
{ state.workspaces.length <= 0 && <option value={NO_WORKSPACE}>{NO_WORKSPACE}</option> }
370364
</select>
371365
</div>
372366
</header>
@@ -404,20 +398,6 @@ export const Workspace = (props: WorkspaceProps) => {
404398
}
405399
</div>
406400
}
407-
<div className='pl-2 remixui_treeview'>
408-
{ false && <FileExplorer
409-
name='browser'
410-
registry={props.registry}
411-
filesProvider={props.browser}
412-
menuItems={['createNewFile', 'createNewFolder', 'publishToGist', canUpload ? 'uploadFile' : '']}
413-
plugin={props.plugin}
414-
focusRoot={state.reset}
415-
contextMenuItems={props.registeredMenuItems}
416-
displayInput={state.displayNewFile}
417-
externalUploads={state.uploadFileEvent}
418-
/>
419-
}
420-
</div>
421401
</div>
422402
</div>
423403
</div>

0 commit comments

Comments
 (0)