Skip to content

Commit 57b2c7b

Browse files
LianaHusAniket-Engg
authored andcommitted
fixing warnings
1 parent f120a74 commit 57b2c7b

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

apps/remix-ide/src/app/plugins/remixGuide.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ export class RemixGuidePlugin extends ViewPlugin {
123123
expandViewEl={
124124
cell.expandViewElement
125125
}
126-
id={cell.title}
126+
key={cell.title}
127127
handleExpand={() => {
128128
this.showVideo = true
129129
this.videoID = cell.expandViewElement.videoID

apps/remix-ide/src/app/plugins/templates-selection/templates-selection-plugin.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,14 +154,15 @@ export class TemplatesSelectionPlugin extends ViewPlugin {
154154
templates(window._intl).map(template => {
155155
return <RemixUIGridSection
156156
plugin={this}
157+
key={template.name}
157158
title={template.name}
158159
hScrollable={false}
159160
>
160161
{template.items.map(item => {
161162
return <RemixUIGridCell
162163
plugin={this}
163164
title={item.displayName}
164-
id={item.name}
165+
key={item.name}
165166
searchKeywords={[item.displayName, item.description, template.name]}
166167
tagList={item.tagList}
167168
classList='TSCellStyle'

apps/remix-ide/src/app/providers/environment-explorer.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ export class EnvironmentExplorer extends ViewPlugin {
110110
classList='EECellStyle'
111111
searchKeywords={['Injected', provider.name, provider.displayName, provider.title, provider.description]}
112112
pinned={this.pinnedProviders.includes(provider.name)}
113-
id={provider.name}
113+
key={provider.name}
114114
pinStateCallback={async (pinned: boolean) => {
115115
if (pinned) {
116116
this.emit('providerPinned', provider.name, provider)
@@ -144,7 +144,7 @@ export class EnvironmentExplorer extends ViewPlugin {
144144
classList='EECellStyle'
145145
searchKeywords={['Remix VMs', provider.name, provider.displayName, provider.title, provider.description]}
146146
pinned={this.pinnedProviders.includes(provider.name)}
147-
id={provider.name}
147+
key={provider.name}
148148
pinStateCallback={async (pinned: boolean) => {
149149
if (pinned) {
150150
this.emit('providerPinned', provider.name, provider)
@@ -177,7 +177,7 @@ export class EnvironmentExplorer extends ViewPlugin {
177177
classList='EECellStyle'
178178
searchKeywords={['Externals', provider.name, provider.displayName, provider.title, provider.description]}
179179
pinned={this.pinnedProviders.includes(provider.name)}
180-
id={provider.name}
180+
key={provider.name}
181181
pinStateCallback={async (pinned: boolean) => {
182182
if (pinned) {
183183
this.emit('providerPinned', provider.name, provider)

libs/remix-ui/grid-view/src/lib/remix-ui-grid-cell.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ interface RemixUIGridCellProps {
2525
children?: ReactNode
2626
expandViewEl?: any
2727
handleExpand?: any
28-
id: string
2928
searchKeywords?: string[]
3029
}
3130

@@ -76,7 +75,7 @@ export const RemixUIGridCell = (props: RemixUIGridCellProps) => {
7675
<div className='d-flex flex-grid'>
7776
<div className={ `${pinned ? "" : "border-dark "}` + "d-flex mx-0 p-2 bg-light border border-secondary remixui_grid_cell_container " + props.classList || ''} data-id={"remixUIGS" + props.title}>
7877
<div className="d-flex remixui_grid_cell w-100 flex-column">
79-
{ !props.hideTitle && <div className='d-flex flex-row pb-1 align-items-end' style={{ minWidth: '8rem', height: '1rem' }}>
78+
{ !props.hideTitle && <div className='d-flex flex-row pb-1 mb-1 align-items-end' style={{ minWidth: '8rem', height: '1rem' }}>
8079
{ props.logo && <img className='remixui_grid_view_logo mr-1' src={props.logo} style={{ width: '1rem', height: '1rem' }}/> }
8180
{ props.logos && props.logos.map((logo) => <img className='remixui_grid_view_logo mr-1' src={logo} style={{ width: '1rem', height: '1rem' }}/>)}
8281
{ props.title &&
@@ -98,7 +97,7 @@ export const RemixUIGridCell = (props: RemixUIGridCellProps) => {
9897
{ filterCon.showPin && <button
9998
className={`${pinned ? 'fa-circle-check text-dark' : 'fa-circle text-secondary'}` + ` fa-regular border-0 mb-0 remixui_grid_cell_pin`}
10099
style={{ fontSize: 'large' }}
101-
data-id={`${pinned ? `${props.id}-pinned` : `${props.id}-unpinned`}`}
100+
data-id={`${pinned ? `${props.title}-pinned` : `${props.title}-unpinned`}`}
102101
onClick={async () => {
103102
if (!props.pinStateCallback) setPinned(!pinned)
104103
if (await props.pinStateCallback(!pinned)) setPinned(!pinned)

0 commit comments

Comments
 (0)