Skip to content

Commit 74cd7f0

Browse files
authored
Merge pull request #4100 from ethereum/festyless
fe style improvements
2 parents 057f269 + bf378d2 commit 74cd7f0

File tree

4 files changed

+23
-15
lines changed

4 files changed

+23
-15
lines changed

libs/remix-ui/workspace/src/lib/components/file-explorer-context-menu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ export const FileExplorerContextMenu = (props: FileExplorerContextMenuProps) =>
111111
return groupedActions.map((groupItem, groupIndex) =>
112112
groupItem.map((item, index) => {
113113
key++
114-
const className = `remixui_liitem ${group !== item.group ? 'border-top' : ''}`
114+
const className = `px-3 remixui_liitem ${group !== item.group ? 'border-top' : ''}`
115115
group = item.group
116116
if (item.name === 'Upload File') {
117117
return (

libs/remix-ui/workspace/src/lib/components/file-explorer-menu.tsx

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,7 @@ export const FileExplorerMenu = (props: FileExplorerMenuProps) => {
6767

6868
return (
6969
<>
70-
<CustomTooltip placement="top" tooltipId="remixuilabelTooltip" tooltipClasses="text-nowrap" tooltipText={props.title}>
71-
<span className="remixui_label" data-path={props.title} style={{fontWeight: 'bold'}}>
72-
{props.title}
73-
</span>
74-
</CustomTooltip>
75-
<span className="pl-0 pb-1">
70+
<span data-id="spanContaining" className="pl-0 pb-1 w-50">
7671
{state.menuItems.map(({action, title, icon, placement}, index) => {
7772
if (action === 'uploadFile') {
7873
return (
@@ -83,7 +78,13 @@ export const FileExplorerMenu = (props: FileExplorerMenuProps) => {
8378
tooltipText={<FormattedMessage id={`filePanel.${action}`} defaultMessage={title} />}
8479
key={`index-${action}-${placement}-${icon}`}
8580
>
86-
<label id={action} style={{fontSize: '1.1rem', cursor: 'pointer'}} data-id={'fileExplorerUploadFile' + action} className={icon + ' mb-0 px-1 remixui_newFile'} key={`index-${action}-${placement}-${icon}`}>
81+
<label
82+
id={action}
83+
style={{fontSize: '1.1rem', cursor: 'pointer'}}
84+
data-id={'fileExplorerUploadFile' + action}
85+
className={icon + ' mx-1 remixui_menuItem'}
86+
key={`index-${action}-${placement}-${icon}`}
87+
>
8788
<input
8889
id="fileUpload"
8990
data-id="fileExplorerFileUpload"
@@ -108,7 +109,13 @@ export const FileExplorerMenu = (props: FileExplorerMenuProps) => {
108109
tooltipText={<FormattedMessage id={`filePanel.${action}`} defaultMessage={title} />}
109110
key={`index-${action}-${placement}-${icon}`}
110111
>
111-
<label id={action} style={{fontSize: '1.1rem', cursor: 'pointer'}} data-id={'fileExplorerUploadFolder' + action} className={icon + ' mb-0 px-1 remixui_newFile'} key={`index-${action}-${placement}-${icon}`}>
112+
<label
113+
id={action}
114+
style={{fontSize: '1.1rem', cursor: 'pointer'}}
115+
data-id={'fileExplorerUploadFolder' + action}
116+
className={icon + ' mx-1 remixui_menuItem'}
117+
key={`index-${action}-${placement}-${icon}`}
118+
>
112119
<input
113120
id="folderUpload"
114121
data-id="fileExplorerFolderUpload"
@@ -151,7 +158,7 @@ export const FileExplorerMenu = (props: FileExplorerMenuProps) => {
151158
state.actions[action]()
152159
}
153160
}}
154-
className={'newFile ' + icon + ' pr-2 pl-1 remixui_newFile'}
161+
className={icon + ' mx-1 remixui_menuItem'}
155162
key={`${action}-${title}-${index}`}
156163
></label>
157164
</CustomTooltip>

libs/remix-ui/workspace/src/lib/components/file-explorer.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React, {useEffect, useState, useRef, SyntheticEvent} from 'react' // eslint-disable-line
22
import {useIntl} from 'react-intl'
3-
import {TreeView, TreeViewItem} from '@remix-ui/tree-view' // eslint-disable-line
3+
import {TreeView} from '@remix-ui/tree-view' // eslint-disable-line
44
import {FileExplorerMenu} from './file-explorer-menu' // eslint-disable-line
55
import {FileExplorerContextMenu} from './file-explorer-context-menu' // eslint-disable-line
66
import {FileExplorerProps, FileType, WorkSpaceState} from '../types'
@@ -358,7 +358,7 @@ export const FileExplorer = (props: FileExplorerProps) => {
358358
data-id={`treeViewDivMenu`}
359359
className={`d-flex flex-row align-items-center`}
360360
>
361-
<span className="w-100 pl-2">
361+
<span className="w-100 pl-2 mt-1">
362362
<div onClick={handleFileExplorerMenuClick}>
363363
<FileExplorerMenu
364364
title={''}
@@ -394,7 +394,8 @@ export const FileExplorer = (props: FileExplorerProps) => {
394394
showIconsMenu={props.showIconsMenu}
395395
hideIconsMenu={props.hideIconsMenu}
396396
/>
397-
))}
397+
))
398+
}
398399
</TreeView>
399400
</div>
400401
<Draggable isDraggable={false} file={{ name: '/', path: '/', type: 'folder', isDirectory: true }} expandedPath={props.expandPath} handleClickFolder={null}>

libs/remix-ui/workspace/src/lib/css/file-explorer.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ input[type="file"] {
2323
.remixui_file {
2424
padding : 4px;
2525
}
26-
.remixui_newFile i {
26+
.remixui_menuItem i {
2727
cursor : pointer;
2828
}
29-
.remixui_newFile:hover {
29+
.remixui_menuItem:hover {
3030
transform : scale(1.3);
3131
}
3232
.remixui_menu {

0 commit comments

Comments
 (0)