Skip to content

Commit fac6fcb

Browse files
authored
Merge pull request #1985 from ethereum/hhhh
fixed icons paddings on verticalicons and PM selection from home
2 parents 1c88c6d + 540756b commit fac6fcb

File tree

5 files changed

+20
-24
lines changed

5 files changed

+20
-24
lines changed

libs/remix-ui/home-tab/src/lib/remix-ui-home-tab.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ export const RemixUiHomeTab = (props: RemixUiHomeTabProps) => {
173173
_paq.push(['trackEvent', 'pluginManager', 'userActivate', 'sourcify'])
174174
}
175175
const startPluginManager = async () => {
176-
await plugin.appManager.activatePlugin('pluginManager')
177176
plugin.verticalIcons.select('pluginManager')
178177
}
179178

libs/remix-ui/vertical-icons-panel/src/lib/components/Home.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ interface HomeProps {
77
function Home ({ verticalIconPlugin }: HomeProps) {
88
return (
99
<div
10-
className="mt-3 my-1 remixui_homeIcon"
10+
className="mt-2 my-1 remixui_homeIcon"
1111
onClick={async () => await verticalIconPlugin.activateHome()}
1212
{...{ plugin: 'home'}}
1313
title="Home"

libs/remix-ui/vertical-icons-panel/src/lib/components/Icon.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ const Icon = ({
8585
return (
8686
<>
8787
<div
88-
className={`remixui_icon m-2 pl-1`}
88+
className={`remixui_icon m-2 pt-1`}
8989
onClick={() => {
9090
(verticalIconPlugin as any).toggle(name)
9191
}}

libs/remix-ui/vertical-icons-panel/src/lib/remix-ui-vertical-icons-panel.css

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
width: 36px;
3030
height: 36px;
3131
border-radius: 8px;
32+
align-items: center;
3233
}
3334
.remixui_icon img {
3435
width: 28px;
@@ -39,15 +40,12 @@
3940

4041
.remixui_icon .selected-dark {
4142
filter: invert(1) grayscale(1);
42-
4343
}
4444

4545
.remixui_icon .selected-light {
4646
filter: invert(0) grayscale(1);
4747
}
4848

49-
.remixui_image {
50-
}
5149
.remixui_icon svg {
5250
width: 28px;
5351
height: 28px;
@@ -119,9 +117,12 @@
119117
}
120118
.remixui_default-icons-container {
121119
border-bottom: 2px solid #3f4455;
120+
text-align: center;
122121
}
123122
.remixui_icon-chevron {
124123
z-index: 1000;
124+
cursor: pointer;
125+
align-items: center;
125126
}
126127

127128
.remixui_settings {
@@ -132,7 +133,3 @@
132133
list-style: none;
133134
margin: 0px;
134135
}
135-
136-
.remixui_icon-chevron {
137-
cursor: pointer;
138-
}

libs/remix-ui/vertical-icons-panel/src/lib/remix-ui-vertical-icons-panel.tsx

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ const RemixUiVerticalIconsPanel = ({
9090
<Chevron
9191
direction='up'
9292
divElementRef={scrollableRef}
93-
cssRule={'fa fa-chevron-up remixui_icon-chevron mt-0 mb-0 ml-1 pl-3'}
93+
cssRule={'fa fa-chevron-up remixui_icon-chevron my-0'}
9494
/>
9595
) : null
9696
}
@@ -109,19 +109,19 @@ const RemixUiVerticalIconsPanel = ({
109109
itemContextAction={itemContextAction}
110110
/>
111111
</div>
112-
<div>
113-
{ scrollableRef.current && scrollableRef.current.scrollHeight > scrollableRef.current.clientHeight ? (<Chevron
114-
divElementRef={scrollableRef}
115-
direction='down'
116-
cssRule={'fa fa-chevron-down remixui_icon-chevron mt-0 mb-0 ml-1 pl-3'}
117-
/>) : null }
118-
<IconList
119-
theme={theme}
120-
icons={icons.filter((p) => p.profile.name === 'settings' || p.profile.name === 'pluginManager')}
121-
verticalIconsPlugin={verticalIconsPlugin}
122-
itemContextAction={itemContextAction}
123-
/>
124-
</div>
112+
<div className="remixui_default-icons-container border-0">
113+
{ scrollableRef.current && scrollableRef.current.scrollHeight > scrollableRef.current.clientHeight ? (<Chevron
114+
divElementRef={scrollableRef}
115+
direction='down'
116+
cssRule={'fa fa-chevron-down remixui_icon-chevron my-0'}
117+
/>) : null }
118+
<IconList
119+
theme={theme}
120+
icons={icons.filter((p) => p.profile.name === 'settings' || p.profile.name === 'pluginManager')}
121+
verticalIconsPlugin={verticalIconsPlugin}
122+
itemContextAction={itemContextAction}
123+
/>
124+
</div>
125125
</div>
126126
</div>
127127
)

0 commit comments

Comments
 (0)