fix(jokes): throw 403 instead of 401 if the use isn't the owner (#86)

MichaelDeBoey · web-flow · commit b783f6e331c1 · 2022-11-25T10:12:20.000-07:00
diff --git a/_official-jokes/app/routes/jokes/$jokeId.tsx b/_official-jokes/app/routes/jokes/$jokeId.tsx
@@ -56,7 +56,7 @@ export const action: ActionFunction = async ({ request, params }) => {
   }
   if (joke.jokesterId !== userId) {
     throw new Response("Pssh, nice try. That's not your joke", {
-      status: 401,
+      status: 403,
     });
   }
   await db.joke.delete({ where: { id: params.jokeId } });
@@ -87,7 +87,7 @@ export function CatchBoundary() {
         </div>
       );
     }
-    case 401: {
+    case 403: {
       return (
         <div className="error-container">
           Sorry, but {params.jokeId} is not your joke.

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ export const action: ActionFunction = async ({ request, params }) => {`
`56`	`56`	`}`
`57`	`57`	`if (joke.jokesterId !== userId) {`
`58`	`58`	`throw new Response("Pssh, nice try. That's not your joke", {`
`59`		`- status: 401,`
	`59`	`+ status: 403,`
`60`	`60`	`});`
`61`	`61`	`}`
`62`	`62`	`await db.joke.delete({ where: { id: params.jokeId } });`
`@@ -87,7 +87,7 @@ export function CatchBoundary() {`
`87`	`87`	`</div>`
`88`	`88`	`);`
`89`	`89`	`}`
`90`		`- case 401: {`
	`90`	`+ case 403: {`
`91`	`91`	`return (`
`92`	`92`	`<div className="error-container">`
`93`	`93`	`Sorry, but {params.jokeId} is not your joke.`