Skip to content

Commit 03f452a

Browse files
committed
Merge pull request #444 from moretti/master
Use `react/lib/Object.assign` instead of `react/lib/merge` and `react/lib/copyProperties`
2 parents a3f488c + 940a0d0 commit 03f452a

File tree

6 files changed

+13
-13
lines changed

6 files changed

+13
-13
lines changed

modules/components/DefaultRoute.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var merge = require('react/lib/merge');
1+
var objectAssign = require('react/lib/Object.assign');
22
var Route = require('./Route');
33

44
/**
@@ -9,7 +9,7 @@ var Route = require('./Route');
99
*/
1010
function DefaultRoute(props) {
1111
return Route(
12-
merge(props, {
12+
objectAssign({}, props, {
1313
path: null,
1414
isDefault: true
1515
})

modules/components/Link.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var React = require('react');
22
var classSet = require('react/lib/cx');
3-
var merge = require('react/lib/merge');
3+
var objectAssign = require('react/lib/Object.assign');
44
var ActiveState = require('../mixins/ActiveState');
55
var Navigation = require('../mixins/Navigation');
66

@@ -93,7 +93,7 @@ var Link = React.createClass({
9393
},
9494

9595
render: function () {
96-
var props = merge(this.props, {
96+
var props = objectAssign({}, this.props, {
9797
href: this.getHref(),
9898
className: this.getClassName(),
9999
onClick: this.handleClick

modules/components/NotFoundRoute.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var merge = require('react/lib/merge');
1+
var objectAssign = require('react/lib/Object.assign');
22
var Route = require('./Route');
33

44
/**
@@ -10,7 +10,7 @@ var Route = require('./Route');
1010
*/
1111
function NotFoundRoute(props) {
1212
return Route(
13-
merge(props, {
13+
objectAssign({}, props, {
1414
path: null,
1515
catchAll: true
1616
})

modules/components/Routes.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
var React = require('react');
22
var warning = require('react/lib/warning');
33
var invariant = require('react/lib/invariant');
4-
var copyProperties = require('react/lib/copyProperties');
4+
var objectAssign = require('react/lib/Object.assign');
55
var HashLocation = require('../locations/HashLocation');
66
var ActiveContext = require('../mixins/ActiveContext');
77
var LocationContext = require('../mixins/LocationContext');
@@ -416,7 +416,7 @@ var Routes = React.createClass({
416416
throw new Error('Passing children to a route handler is not supported');
417417

418418
return route.props.handler(
419-
copyProperties(props, addedProps)
419+
objectAssign(props, addedProps)
420420
);
421421
}.bind(this, props);
422422
});

modules/mixins/ActiveContext.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
var React = require('react');
2-
var copyProperties = require('react/lib/copyProperties');
2+
var objectAssign = require('react/lib/Object.assign');
33

44
/**
55
* A mixin for components that store the active state of routes,
@@ -40,14 +40,14 @@ var ActiveContext = {
4040
* Returns a read-only object of the currently active URL parameters.
4141
*/
4242
getActiveParams: function () {
43-
return copyProperties({}, this.state.activeParams);
43+
return objectAssign({}, this.state.activeParams);
4444
},
4545

4646
/**
4747
* Returns a read-only object of the currently active query parameters.
4848
*/
4949
getActiveQuery: function () {
50-
return copyProperties({}, this.state.activeQuery);
50+
return objectAssign({}, this.state.activeQuery);
5151
},
5252

5353
childContextTypes: {

modules/utils/ServerRendering.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ var ReactMarkupChecksum = require('react/lib/ReactMarkupChecksum');
44
var ReactServerRenderingTransaction = require('react/lib/ReactServerRenderingTransaction');
55

66
var cloneWithProps = require('react/lib/cloneWithProps');
7-
var copyProperties = require('react/lib/copyProperties');
7+
var objectAssign = require('react/lib/Object.assign');
88
var instantiateReactComponent = require('react/lib/instantiateReactComponent');
99
var invariant = require('react/lib/invariant');
1010

@@ -16,7 +16,7 @@ function cloneRoutesForServerRendering(routes) {
1616
}
1717

1818
function mergeStateIntoInitialProps(state, props) {
19-
copyProperties(props, {
19+
objectAssign(props, {
2020
initialPath: state.path,
2121
initialMatches: state.matches,
2222
initialActiveRoutes: state.activeRoutes,

0 commit comments

Comments
 (0)