Merge pull request #499 from vladimir-vg/will-transition-to-query-fix

[fixed] Now execute willTransition* hooks even if only query part was changed

Author: ryanflorence

modules/__tests__/Router-test.js

@@ -532,6 +532,46 @@ describe('Router', function () {
         done();
       });
     });
+
+    it('execute willTransition* callbacks when query changes', function (done) {
+      var fromCallbackExecuted = false;
+      var Spoon = React.createClass({
+        statics: {
+          willTransitionTo: function (transition, params, query) {
+            if (query['filter'] === 'first') {
+              return; // skip first transition
+            }
+
+            expect(query['filter']).toEqual('second');
+            expect(fromCallbackExecuted).toBe(true);
+            done();
+          },
+
+          willTransitionFrom: function (transition, element) {
+            fromCallbackExecuted = true;
+          }
+        },
+
+        render: function () {
+          return <h1>Spoon</h1>;
+        }
+      });
+
+      var routes = (
+        <Route handler={Nested} path='/'>
+          <Route name="spoon" handler={Spoon}/>
+        </Route>
+      );
+
+      TestLocation.history = [ '/spoon?filter=first' ];
+
+      var div = document.createElement('div');
+      Router.run(routes, TestLocation, function (Handler, state) {
+        React.render(<Handler/>, div);
+      });
+
+      TestLocation.push('/spoon?filter=second');
+    });
   });
 
   describe('willTransitionFrom', function () {
@@ -566,7 +606,6 @@ describe('Router', function () {
         });
       });
     });
-
   });
 
 });

modules/utils/createRouter.js

@@ -334,6 +334,16 @@ function createRouter(options) {
           toRoutes = nextRoutes;
         }
 
+        // If routes' hooks arrays are empty, then we transition to current route.
+        // But path is somehow still get changed.
+        // That could be only because of route query changes.
+        // Need to push current route to routes' hooks arrays.
+        if (!toRoutes.length && !fromRoutes.length) {
+          var currentRoute = state.routes[state.routes.length-1];
+          fromRoutes = [currentRoute];
+          toRoutes = [currentRoute];
+        }
+
         var transition = new Transition(path, this.replaceWith.bind(this, path));
         pendingTransition = transition;