Skip to content

Commit 115459f

Browse files
committed
Add workflow to close new feature PRs that haven't gone through a proposal process
1 parent 8791247 commit 115459f

File tree

2 files changed

+33
-0
lines changed

2 files changed

+33
-0
lines changed
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# Close a singular pull request that implements a feature that has not
2+
# gone through the Proposal process
3+
# Triggered by adding the `feature-request` label to an issue
4+
5+
name: 🚪 Close Feature Pull Request
6+
7+
on:
8+
pull_request:
9+
types: [labeled]
10+
11+
jobs:
12+
close-feature-pr:
13+
name: 🚪 Close Feature Pull Request
14+
if: github.repository == 'remix-run/react-router' && github.event.label.name == 'feature-request'
15+
runs-on: ubuntu-latest
16+
steps:
17+
- name: ⬇️ Checkout repo
18+
uses: actions/checkout@v4
19+
20+
- name: 🚪 Close PR
21+
env:
22+
GH_TOKEN: ${{ github.token }}
23+
run: |
24+
gh pr comment ${{ github.event.pull_request.number }} -F ./scripts/close-feature-pr.md
25+
gh pr edit ${{ github.event.pull_request.number }} --remove-label ${{ github.event.label.name }}
26+
gh pr close ${{ github.event.pull_request.number }}

scripts/close-feature-pr.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
To align with our new [Open Governance](https://remix.run/blog/rr-governance) model, we are now asking that all new features go through the Proposal/RFC process and that we don't open PRs until a proposal has been been accepted and advanced to Stage 1.
2+
3+
If this feature doesn't have a Proposal, please [open one](https://github.com/remix-run/react-router/discussions/new?category=proposals) so we can evaluate/discuss the proposed feature. You can link to this PR as an example of a potential implementation and we can re-open it if the proposal advances.
4+
5+
If this PR already has a Proposal but it has not yet been accepted, let's continue the discussion in the Proposal until it gets accepted and then we can look to open a PR. Feel free to link to this PR or to a branch in a forked repo to show what a potential implementation might look like.
6+
7+
If you have any questions, you can always reach out on [Discord](https://rmx.as/discord). Thanks again for providing feedback and helping us make React Router even better!

0 commit comments

Comments
 (0)