Skip to content

Commit 161a13b

Browse files
committed
Update @vitejs/plugin-rsc to fix HMR issues
1 parent e3d4974 commit 161a13b

File tree

8 files changed

+23
-29
lines changed

8 files changed

+23
-29
lines changed

integration/helpers/rsc-vite-framework/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"@vanilla-extract/css": "^1.17.4",
2222
"@vanilla-extract/vite-plugin": "^5.1.1",
2323
"@vitejs/plugin-react": "^4.5.2",
24-
"@vitejs/plugin-rsc": "0.4.24",
24+
"@vitejs/plugin-rsc": "https://pkg.pr.new/@vitejs/plugin-rsc@788",
2525
"cross-env": "^7.0.3",
2626
"typescript": "^5.1.6",
2727
"vite": "^6.2.0",

integration/helpers/rsc-vite/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"typecheck": "tsc"
1111
},
1212
"devDependencies": {
13-
"@vitejs/plugin-rsc": "0.4.24",
13+
"@vitejs/plugin-rsc": "https://pkg.pr.new/@vitejs/plugin-rsc@788",
1414
"@types/express": "^5.0.0",
1515
"@types/node": "^22.13.1",
1616
"@types/react": "^19.1.8",

integration/vite-css-test.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -594,14 +594,10 @@ async function hmrWorkflow({
594594
`CSS update for ${routeFile}`,
595595
).toHaveCSS("padding", NEW_PADDING);
596596

597-
// TODO: Fix state preservation when changing these styles in RSC
598-
// Framework mode. This appears to be a deeper HMR issue with
599-
// changing non-React modules imported by the route.
597+
// TODO: Fix state preservation for Vanilla Extract HMR
600598
if (
601599
templateName.includes("rsc") &&
602-
(file === "styles.module.css" ||
603-
file === "styles-postcss-linked.css" ||
604-
file === "styles-vanilla-global.css.ts")
600+
file === "styles-vanilla-global.css.ts"
605601
) {
606602
continue;
607603
}

integration/vite-hmr-hdr-test.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -352,9 +352,6 @@ async function workflow({
352352
await expect(hdrStatus).toHaveText(
353353
"HDR updated: route & direct 2 & indirect 2",
354354
);
355-
// TODO: Investigate why this is flaky in CI for RSC Framework Mode
356-
if (!templateName.includes("rsc")) {
357-
await expect(input).toHaveValue("stateful");
358-
}
355+
await expect(input).toHaveValue("stateful");
359356
expect(page.errors).toEqual([]);
360357
}

packages/react-router-dev/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
"@babel/types": "^7.27.7",
7979
"@npmcli/package-json": "^4.0.1",
8080
"@react-router/node": "workspace:*",
81-
"@vitejs/plugin-rsc": "0.4.24",
81+
"@vitejs/plugin-rsc": "https://pkg.pr.new/@vitejs/plugin-rsc@788",
8282
"arg": "^5.0.1",
8383
"babel-dead-code-elimination": "^1.0.6",
8484
"chokidar": "^4.0.0",

playground/rsc-vite-framework/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"@types/react": "^19.1.8",
1919
"@types/react-dom": "^19.1.6",
2020
"@vitejs/plugin-react": "^4.5.2",
21-
"@vitejs/plugin-rsc": "0.4.24",
21+
"@vitejs/plugin-rsc": "https://pkg.pr.new/@vitejs/plugin-rsc@788",
2222
"cross-env": "^7.0.3",
2323
"remark-frontmatter": "^5.0.0",
2424
"remark-mdx-frontmatter": "^5.2.0",

playground/rsc-vite/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"@types/react": "^19.1.8",
1616
"@types/react-dom": "^19.1.6",
1717
"@vitejs/plugin-react": "^4.5.2",
18-
"@vitejs/plugin-rsc": "0.4.24",
18+
"@vitejs/plugin-rsc": "https://pkg.pr.new/@vitejs/plugin-rsc@788",
1919
"cross-env": "^7.0.3",
2020
"typescript": "^5.1.6",
2121
"vite": "^6.2.0"

pnpm-lock.yaml

Lines changed: 15 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)