Skip to content

Commit 28cd222

Browse files
committed
Use built-in dev request handler
1 parent e495e0e commit 28cd222

File tree

3 files changed

+8
-38
lines changed

3 files changed

+8
-38
lines changed

integration/helpers/vite.ts

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -188,19 +188,6 @@ export const EXPRESS_SERVER = (args: {
188188
},
189189
})
190190
);
191-
192-
const requestListener =
193-
viteDevServer
194-
? async (req, res) => {
195-
// In dev mode, ensure we load a fresh request handler every request
196-
const rscEntry = await viteDevServer.environments.rsc.runner.import(
197-
"virtual:react-router/unstable_rsc/rsc-entry",
198-
);
199-
return createRequestListener(rscEntry.default)(req, res);
200-
}
201-
// In production, get the static request handler from the build output
202-
: createRequestListener((await import("./build/server/index.js")).default);
203-
204191
const app = express();
205192
206193
if (viteDevServer) {
@@ -210,6 +197,7 @@ export const EXPRESS_SERVER = (args: {
210197
"/assets",
211198
express.static("build/client/assets", { immutable: true, maxAge: "1y" })
212199
);
200+
app.all("*", createRequestListener((await import("./build/server/index.js")).default));
213201
}
214202
215203
${args?.customLogic || ""}

integration/vite-basename-test.ts

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -116,20 +116,11 @@ const customServerFile = ({
116116
})
117117
);
118118
119-
const requestListener = viteDevServer
120-
? async (req, res) => {
121-
// In dev mode, ensure we load a fresh request handler every request
122-
const rscEntry = await viteDevServer.environments.rsc.runner.import(
123-
"virtual:react-router/unstable_rsc/rsc-entry",
124-
);
125-
return createRequestListener(rscEntry.default)(req, res);
126-
}
127-
// In production, get the static request handler from the build output
128-
: createRequestListener((await import("./build/server/index.js")).default);
129-
130119
const app = express();
131120
app.use("${base}", viteDevServer?.middlewares || express.static("build/client"));
132-
app.all("${basename}*", requestListener);
121+
if (!viteDevServer) {
122+
app.all("${basename}*", createRequestListener((await import("./build/server/index.js")).default));
123+
}
133124
app.get("*", (_req, res) => {
134125
res.setHeader("content-type", "text/html")
135126
res.end('React Router app is at <a href="${basename}">${basename}</a>');

playground/rsc-vite-framework/start-vite-middleware.js

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,6 @@ const viteDevServer =
1212
}),
1313
);
1414

15-
const requestListener = viteDevServer
16-
? async (req, res) => {
17-
// In dev mode, ensure we load a fresh request handler every request
18-
const rscEntry = await viteDevServer.environments.rsc.runner.import(
19-
"virtual:react-router/unstable_rsc/rsc-entry",
20-
);
21-
return createRequestListener(rscEntry.default)(req, res);
22-
}
23-
: // In production, get the static request handler from the build output
24-
createRequestListener((await import("./build/server/index.js")).default);
25-
2615
const app = express();
2716

2817
if (viteDevServer) {
@@ -33,10 +22,12 @@ if (viteDevServer) {
3322
express.static("build/client/assets", { immutable: true, maxAge: "1y" }),
3423
);
3524
app.use(express.static("build/client"));
25+
app.all(
26+
"*",
27+
createRequestListener((await import("./build/server/index.js")).default),
28+
);
3629
}
3730

38-
app.all("*", requestListener);
39-
4031
const port = process.env.PORT || 3000;
4132
app.listen(port);
4233
console.log(`Server listening on port ${port} (http://localhost:${port})`);

0 commit comments

Comments
 (0)