Don't crash on invalid uri query parameters. (#3453)

* Don't crash on invalid uri query parameters

* Add try/catch at matchPattern function in matchRoutes.js and testing.

* Fix test 'handles error that are not valid URI character'

Author: bae-unidev

modules/PatternUtils.js

@@ -71,6 +71,7 @@ export function compilePattern(pattern) {
  * - **             Consumes (greedy) all characters up to the next character
  *                  in the pattern, or to the end of the URL if there is none
  *
+ *  The function calls callback(error, matched) when finished.
  * The return value is an object with the following properties:
  *
  * - remainingPathname

modules/__tests__/Router-test.js

@@ -276,6 +276,19 @@ describe('Router', function () {
       })
     })
 
+    it('handles error that are not valid URI character', function (done) {
+      const errorSpy = expect.createSpy()
+
+      render((
+        <Router history={createHistory('/%')} onError={errorSpy}>
+          <Route path="*" />
+        </Router>
+      ), node, function () {
+        expect(errorSpy).toHaveBeenCalled()
+        done()
+      })
+    })
+
   })
 
   describe('render prop', function () {

modules/matchRoutes.js

@@ -88,13 +88,17 @@ function matchRouteDeep(
   // Only try to match the path if the route actually has a pattern, and if
   // we're not just searching for potential nested absolute paths.
   if (remainingPathname !== null && pattern) {
-    const matched = matchPattern(pattern, remainingPathname)
-    if (matched) {
-      remainingPathname = matched.remainingPathname
-      paramNames = [ ...paramNames, ...matched.paramNames ]
-      paramValues = [ ...paramValues, ...matched.paramValues ]
-    } else {
-      remainingPathname = null
+    try {
+      const matched = matchPattern(pattern, remainingPathname)
+      if (matched) {
+        remainingPathname = matched.remainingPathname
+        paramNames = [ ...paramNames, ...matched.paramNames ]
+        paramValues = [ ...paramValues, ...matched.paramValues ]
+      } else {
+        remainingPathname = null
+      }
+    } catch (error) {
+      callback(error)
     }
 
     // By assumption, pattern is non-empty here, which is the prerequisite for