You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+9-21Lines changed: 9 additions & 21 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,8 +2,7 @@ Thanks for contributing, you rock!
2
2
3
3
If you use our code, it is now *our* code.
4
4
5
-
Please read https://reactjs.org/ and the Code of Conduct before opening an
6
-
issue.
5
+
Please read https://reactjs.org/ and the Code of Conduct before opening an issue.
7
6
8
7
-[Think You Found a Bug?](#bug)
9
8
-[Proposing New or Changed API?](#api)
@@ -15,24 +14,19 @@ issue.
15
14
<aname="bug"/>
16
15
## Think You Found a Bug?
17
16
18
-
Please provide a test case of some sort. Best is a pull request with a
19
-
failing test. Next is a link to codepen/jsbin or repository that
20
-
illustrates the bug. Finally, some copy/pastable code is acceptable.
17
+
Please provide a test case of some sort. Best is a pull request with a failing test. Next is a link to codepen/jsbin or repository that illustrates the bug. Finally, some copy/pastable code is acceptable.
21
18
22
19
If you don't provide a test case, the issue will be closed.
23
20
24
21
<aname="api"/>
25
22
## Proposing New or Changed API?
26
23
27
-
Please provide thoughtful comments and some sample code. Proposals
28
-
without substance will be closed.
24
+
Please provide thoughtful comments and some sample code. Proposals without substance will be closed.
29
25
30
26
<aname="attention"/>
31
27
## Issue Not Getting Attention?
32
28
33
-
If you need a bug fixed and nobody is fixing it, it is your
34
-
responsibility to fix it. Issues with no activity for 30 days may be
35
-
closed.
29
+
If you need a bug fixed and nobody is fixing it, it is your responsibility to fix it. Issues with no activity for 30 days may be closed.
36
30
37
31
<aname="pr"/>
38
32
## Making a Pull Request?
@@ -45,23 +39,17 @@ All commits that fix bugs or add features need a test.
45
39
46
40
### Changelog
47
41
48
-
All commits that change or add to the API must be done in a pull request
49
-
that also:
42
+
All commits that change or add to the API must be done in a pull request that also:
50
43
51
-
- Add an entry to `CHANGES.md` with clear steps for updating code for
52
-
changed or removed API.
44
+
- Adds an entry to `CHANGES.md` with clear steps for updating code for changed or removed API
53
45
- Updates examples
54
46
- Updates the docs
55
47
56
48
## Development
57
49
58
-
-`npm test` will fire up a karma test runner and watch for changes
59
-
-`npm start` fires up a webpack dev server that will watch
60
-
for changes and build the examples
50
+
-`npm test` starts a karma test runner and watch for changes
51
+
-`npm start` starts a webpack dev server that will watch for changes and build the examples
61
52
62
53
## Hacking
63
54
64
-
The best way to hack on the router is to symlink it into your project
65
-
using [`npm link`](https://docs.npmjs.com/cli/link). Then, use `npm run watch`
66
-
to automatically watch the `modules` directory and output a new `build`
67
-
every time something changes.
55
+
The best way to hack on the router is to symlink it into your project using [`npm link`](https://docs.npmjs.com/cli/link). Then, use `npm run watch` to automatically watch the `modules` directory and output a new build every time something changes.
0 commit comments