Skip to content

Commit 50115a3

Browse files
Update @vitejs/plugin-rsc to fix HMR issues (#14254)
1 parent e3d4974 commit 50115a3

File tree

7 files changed

+26
-45
lines changed

7 files changed

+26
-45
lines changed

integration/helpers/rsc-vite-framework/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"@vanilla-extract/css": "^1.17.4",
2222
"@vanilla-extract/vite-plugin": "^5.1.1",
2323
"@vitejs/plugin-react": "^4.5.2",
24-
"@vitejs/plugin-rsc": "0.4.24",
24+
"@vitejs/plugin-rsc": "0.4.25",
2525
"cross-env": "^7.0.3",
2626
"typescript": "^5.1.6",
2727
"vite": "^6.2.0",

integration/helpers/rsc-vite/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"typecheck": "tsc"
1111
},
1212
"devDependencies": {
13-
"@vitejs/plugin-rsc": "0.4.24",
13+
"@vitejs/plugin-rsc": "0.4.25",
1414
"@types/express": "^5.0.0",
1515
"@types/node": "^22.13.1",
1616
"@types/react": "^19.1.8",

integration/vite-css-test.ts

Lines changed: 7 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -551,15 +551,6 @@ async function hmrWorkflow({
551551
file: "styles-bundled.css",
552552
selector: "#css-bundled",
553553
},
554-
// TODO: Fix HMR for CSS Modules in server-first routes in RSC Framework mode
555-
...(routeBase === "rsc-server-first-route"
556-
? []
557-
: ([
558-
{
559-
file: "styles.module.css",
560-
selector: "#css-modules",
561-
},
562-
] as const)),
563554
{
564555
file: "styles-postcss-linked.css",
565556
selector: "#css-postcss-linked",
@@ -568,13 +559,15 @@ async function hmrWorkflow({
568559
file: "styles-vanilla-global.css.ts",
569560
selector: "#css-vanilla-global",
570561
},
571-
// TODO: Fix HMR for locally scoped Vanilla Extract styles in RSC
572-
// Framework mode. May require changes to the RSC plugin, or Vanilla
573-
// Extract. Userland workaround for now:
574-
// https://github.com/pawelblaszczyk5/vite-rsc-experiments/blob/643649f2e6562c859d9612126bfc3a183e03c7b5/apps/vanilla-extract/vite.config.ts
575-
...(templateName.includes("rsc")
562+
// TODO: Fix HMR for CSS Modules and locally scoped Vanilla Extract in
563+
// server-first routes in RSC Framework mode
564+
...(routeBase === "rsc-server-first-route"
576565
? []
577566
: ([
567+
{
568+
file: "styles.module.css",
569+
selector: "#css-modules",
570+
},
578571
{
579572
file: "styles-vanilla-local.css.ts",
580573
selector: "#css-vanilla-local",
@@ -594,18 +587,6 @@ async function hmrWorkflow({
594587
`CSS update for ${routeFile}`,
595588
).toHaveCSS("padding", NEW_PADDING);
596589

597-
// TODO: Fix state preservation when changing these styles in RSC
598-
// Framework mode. This appears to be a deeper HMR issue with
599-
// changing non-React modules imported by the route.
600-
if (
601-
templateName.includes("rsc") &&
602-
(file === "styles.module.css" ||
603-
file === "styles-postcss-linked.css" ||
604-
file === "styles-vanilla-global.css.ts")
605-
) {
606-
continue;
607-
}
608-
609590
// Ensure CSS updates were handled by HMR
610591
await expect(input, `State preservation for ${routeFile}`).toHaveValue(
611592
routeFile,

packages/react-router-dev/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
"@babel/types": "^7.27.7",
7979
"@npmcli/package-json": "^4.0.1",
8080
"@react-router/node": "workspace:*",
81-
"@vitejs/plugin-rsc": "0.4.24",
81+
"@vitejs/plugin-rsc": "0.4.25",
8282
"arg": "^5.0.1",
8383
"babel-dead-code-elimination": "^1.0.6",
8484
"chokidar": "^4.0.0",

playground/rsc-vite-framework/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"@types/react": "^19.1.8",
1919
"@types/react-dom": "^19.1.6",
2020
"@vitejs/plugin-react": "^4.5.2",
21-
"@vitejs/plugin-rsc": "0.4.24",
21+
"@vitejs/plugin-rsc": "0.4.25",
2222
"cross-env": "^7.0.3",
2323
"remark-frontmatter": "^5.0.0",
2424
"remark-mdx-frontmatter": "^5.2.0",

playground/rsc-vite/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"@types/react": "^19.1.8",
1616
"@types/react-dom": "^19.1.6",
1717
"@vitejs/plugin-react": "^4.5.2",
18-
"@vitejs/plugin-rsc": "0.4.24",
18+
"@vitejs/plugin-rsc": "0.4.25",
1919
"cross-env": "^7.0.3",
2020
"typescript": "^5.1.6",
2121
"vite": "^6.2.0"

pnpm-lock.yaml

Lines changed: 14 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)