Skip to content

Commit 62b32ed

Browse files
committed
Revert functional changes
1 parent 1541ce0 commit 62b32ed

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

packages/react-router/lib/router/router.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,6 @@ export interface StaticHandler {
437437
r: Request,
438438
args?: {
439439
filterMatchesToLoad?: (match: AgnosticDataRouteMatch) => boolean;
440-
skipRevalidation?: boolean;
441440
},
442441
) => Promise<StaticHandlerContext | Response>,
443442
) => MaybePromise<Response>;
@@ -3558,7 +3557,7 @@ export function createStaticHandler(
35583557
skipLoaderErrorBubbling,
35593558
skipRevalidation,
35603559
dataStrategy,
3561-
generateMiddlewareResponse,
3560+
generateMiddlewareResponse: generateMiddlewareResponse,
35623561
}: Parameters<StaticHandler["query"]>[1] = {},
35633562
): Promise<StaticHandlerContext | Response> {
35643563
let url = new URL(request.url);
@@ -3626,7 +3625,6 @@ export function createStaticHandler(
36263625
// redirects from loaders after a server action, etc.
36273626
// - If we decide this isn't warranted than the stream implementation
36283627
// can simplify and potentially even collapse back into respond()
3629-
36303628
if (generateMiddlewareResponse) {
36313629
invariant(
36323630
requestContext instanceof RouterContextProvider,
@@ -3657,7 +3655,6 @@ export function createStaticHandler(
36573655
filterMatchesToLoad?:
36583656
| ((match: AgnosticDataRouteMatch) => boolean)
36593657
| undefined;
3660-
skipRevalidation?: boolean;
36613658
} = {},
36623659
) => {
36633660
let result = await queryImpl(
@@ -3671,7 +3668,7 @@ export function createStaticHandler(
36713668
"filterMatchesToLoad" in opts
36723669
? (opts.filterMatchesToLoad ?? null)
36733670
: null,
3674-
opts?.skipRevalidation ?? skipRevalidation === true,
3671+
skipRevalidation === true,
36753672
);
36763673

36773674
if (isResponse(result)) {
@@ -3834,7 +3831,7 @@ export function createStaticHandler(
38343831
routeId,
38353832
requestContext,
38363833
dataStrategy,
3837-
generateMiddlewareResponse,
3834+
generateMiddlewareResponse: generateMiddlewareResponse,
38383835
}: Parameters<StaticHandler["queryRoute"]>[1] = {},
38393836
): Promise<any> {
38403837
let url = new URL(request.url);

packages/react-router/lib/server-runtime/single-fetch.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -144,15 +144,10 @@ export async function singleFetchLoaders(
144144
requestContext: loadContext,
145145
filterMatchesToLoad: (m) => !loadRouteIds || loadRouteIds.has(m.route.id),
146146
skipLoaderErrorBubbling: true,
147-
skipRevalidation: true,
148147
generateMiddlewareResponse: build.future.v8_middleware
149148
? async (query) => {
150149
try {
151-
let innerResult = await query(handlerRequest, {
152-
filterMatchesToLoad: (m) =>
153-
!loadRouteIds || loadRouteIds.has(m.route.id),
154-
skipRevalidation: true,
155-
});
150+
let innerResult = await query(handlerRequest);
156151
return handleQueryResult(innerResult);
157152
} catch (error) {
158153
return handleQueryError(error);

0 commit comments

Comments
 (0)