typegen: custom app dir test (#12236)

* refactor tests

* typegen: simplify vite.config.ts for tests

* typegen: add test for custom app dir

Author: pcattori

integration/typegen-test.ts

@@ -1,7 +1,9 @@
 import { spawnSync } from "node:child_process";
+import * as path from "node:path";
 
 import { expect, test } from "@playwright/test";
 import dedent from "dedent";
+import fse from "fs-extra";
 
 import { createProject } from "./helpers/vite";
 
@@ -22,13 +24,9 @@ function typecheck(cwd: string) {
 
 const viteConfig = tsx`
   import { reactRouter } from "@react-router/dev/vite";
-  import tsconfigPaths from "vite-tsconfig-paths";
 
   export default {
-    plugins: [
-      reactRouter(),
-      tsconfigPaths()
-    ],
+    plugins: [reactRouter()],
   };
 `;
 
@@ -59,24 +57,46 @@ test.describe("typegen", () => {
     expect(proc.status).toBe(0);
   });
 
-  test("repeated param", async () => {
-    const cwd = await createProject({
-      "vite.config.ts": viteConfig,
-      "app/routes/repeated.$id.($id).$id.tsx": tsx`
-        import type { Route } from "./+types.repeated.$id.($id).$id"
-
-        function assertType<T>(t: T) {}
+  test.describe("params", () => {
+    test("repeated", async () => {
+      const cwd = await createProject({
+        "vite.config.ts": viteConfig,
+        "app/routes/repeated.$id.($id).$id.tsx": tsx`
+          import type { Route } from "./+types.repeated.$id.($id).$id"
+
+          function assertType<T>(t: T) {}
+
+          export function loader({ params }: Route.LoaderArgs) {
+            assertType<[string, string | undefined, string]>(params.id)
+            return null
+          }
+        `,
+      });
+      const proc = typecheck(cwd);
+      expect(proc.stdout.toString()).toBe("");
+      expect(proc.stderr.toString()).toBe("");
+      expect(proc.status).toBe(0);
+    });
 
-        export function loader({ params }: Route.LoaderArgs) {
-          assertType<[string, string | undefined, string]>(params.id)
-          return null
-        }
-      `,
+    test("splat", async () => {
+      const cwd = await createProject({
+        "vite.config.ts": viteConfig,
+        "app/routes/splat.$.tsx": tsx`
+          import type { Route } from "./+types.splat.$"
+
+          function assertType<T>(t: T) {}
+
+          export function loader({ params }: Route.LoaderArgs) {
+            assertType<string>(params["*"])
+            return null
+          }
+        `,
+      });
+      const proc = typecheck(cwd);
+      expect(proc.stdout.toString()).toBe("");
+      expect(proc.stderr.toString()).toBe("");
+      expect(proc.status).toBe(0);
     });
-    const proc = typecheck(cwd);
-    expect(proc.stdout.toString()).toBe("");
-    expect(proc.stderr.toString()).toBe("");
-    expect(proc.status).toBe(0);
   });
 
   test("clientLoader.hydrate = true", async () => {
@@ -112,20 +132,33 @@ test.describe("typegen", () => {
     expect(proc.status).toBe(0);
   });
 
-  test("splat", async () => {
+  test("custom app dir", async () => {
     const cwd = await createProject({
-      "vite.config.ts": viteConfig,
-      "app/routes/splat.$.tsx": tsx`
-        import type { Route } from "./+types.splat.$"
+      "vite.config.ts": tsx`
+        import { reactRouter } from "@react-router/dev/vite";
+
+        export default {
+          plugins: [reactRouter({ appDirectory: "src/myapp" })],
+        };
+      `,
+      "app/routes/products.$id.tsx": tsx`
+        import type { Route } from "./+types.products.$id"
 
         function assertType<T>(t: T) {}
 
         export function loader({ params }: Route.LoaderArgs) {
-          assertType<string>(params["*"])
-          return null
+          assertType<string>(params.id)
+          return { planet: "world" }
+        }
+
+        export default function Component({ loaderData }: Route.ComponentProps) {
+          assertType<string>(loaderData.planet)
+          return <h1>Hello, {loaderData.planet}!</h1>
         }
       `,
     });
+    fse.moveSync(path.join(cwd, "app"), path.join(cwd, "src/myapp"));
+
     const proc = typecheck(cwd);
     expect(proc.stdout.toString()).toBe("");
     expect(proc.stderr.toString()).toBe("");