Skip to content

Commit a579835

Browse files
authored
ci: uppercase ENV, changesets output is camelCase (#10036)
Signed-off-by: Logan McAnsh <[email protected]>
1 parent d6fbfab commit a579835

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/release.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
if: github.repository == 'remix-run/react-router'
1616
runs-on: ubuntu-latest
1717
outputs:
18-
published_packages: ${{ steps.changesets.outputs.published_packages }}
18+
published_packages: ${{ steps.changesets.outputs.publishedPackages }}
1919
published: ${{ steps.changesets.outputs.published }}
2020
steps:
2121
- name: 🛑 Cancel Previous Runs
@@ -83,15 +83,15 @@ jobs:
8383
package_version=$(node ./scripts/release/find-release-from-changeset.js)
8484
echo "package_version=${package_version}" >> $GITHUB_OUTPUT
8585
env:
86-
package_version_to_follow: "react-router"
87-
published_packages: ${{ needs.release.outputs.published_packages }}
86+
PACKAGE_VERSION_TO_FOLLOW: "react-router"
87+
PUBLISHED_PACKAGES: ${{ needs.release.outputs.published_packages }}
8888

8989
comment:
9090
name: 📝 Comment on related issues and pull requests
9191
if: github.repository == 'remix-run/react-router' && needs.find_package_version.outputs.packageVersion != ''
9292
needs: [release, find_package_version]
9393
uses: ./.github/workflows/release-comments.yml
9494
with:
95-
ref: refs/tags/remix@${{ needs.find_package_version.outputs.packageVersion }}
95+
ref: refs/tags/react-router@${{ needs.find_package_version.outputs.packageVersion }}
9696
package_version_to_follow: "react-router"
9797
release_branch: ${{ github.ref_name }}

scripts/release/find-release-from-changeset.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ function findReleaseFromChangeset(publishedPackages, packageVersionToFollow) {
3232
}
3333

3434
findReleaseFromChangeset(
35-
process.env.published_packages,
36-
process.env.package_version_to_follow
35+
process.env.PUBLISHED_PACKAGES,
36+
process.env.PACKAGE_VERSION_TO_FOLLOW
3737
);

0 commit comments

Comments
 (0)