Update minimum version to node 20

brophdawg11 · brophdawg11 · commit a7dd7794487d · 2024-10-21T15:36:15.000-04:00
diff --git a/.github/workflows/integration-full.yml b/.github/workflows/integration-full.yml
@@ -34,7 +34,7 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "ubuntu-latest"
-      node_version: "[18, 20]"
+      node_version: "[20, 22]"
       browser: '["chromium", "firefox"]'
 
   integration-windows:
@@ -43,7 +43,7 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "windows-latest"
-      node_version: "[18, 20]"
+      node_version: "[20, 22]"
       browser: '["msedge"]'
 
   integration-macos:
@@ -52,5 +52,5 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "macos-latest"
-      node_version: "[18, 20]"
+      node_version: "[20, 22]"
       browser: '["webkit"]'
diff --git a/.github/workflows/integration-pr-ubuntu.yml b/.github/workflows/integration-pr-ubuntu.yml
@@ -31,5 +31,5 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "ubuntu-latest"
-      node_version: "[20]"
+      node_version: "[22]"
       browser: '["chromium"]'
diff --git a/.github/workflows/integration-pr-windows-macos.yml b/.github/workflows/integration-pr-windows-macos.yml
@@ -21,7 +21,7 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "ubuntu-latest"
-      node_version: "[20]"
+      node_version: "[22]"
       browser: '["firefox"]'
 
   integration-msedge:
@@ -30,7 +30,7 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "windows-latest"
-      node_version: "[20]"
+      node_version: "[22]"
       browser: '["msedge"]'
 
   integration-webkit:
@@ -39,5 +39,5 @@ jobs:
     uses: ./.github/workflows/shared-integration.yml
     with:
       os: "macos-latest"
-      node_version: "[20]"
+      node_version: "[22]"
       browser: '["webkit"]'
diff --git a/.github/workflows/shared-integration.yml b/.github/workflows/shared-integration.yml
@@ -9,7 +9,7 @@ on:
       node_version:
         required: true
         # this is limited to string | boolean | number (https://github.community/t/can-action-inputs-be-arrays/16457)
-        # but we want to pass an array (node_version: "[18, 20]"),
+        # but we want to pass an array (node_version: "[20, 22]"),
         # so we'll need to manually stringify it for now
         type: string
       browser:
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -26,8 +26,8 @@ jobs:
       fail-fast: false
       matrix:
         node:
-          - 18
           - 20
+          - 22
 
     runs-on: ubuntu-latest
 
diff --git a/integration/helpers/node-template/package.json b/integration/helpers/node-template/package.json
@@ -34,6 +34,6 @@
     "typescript": "^5.1.0"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   }
 }
diff --git a/integration/helpers/vite-cloudflare-template/package.json b/integration/helpers/vite-cloudflare-template/package.json
@@ -30,6 +30,6 @@
     "wrangler": "^3.28.2"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   }
 }
diff --git a/integration/helpers/vite-template/package.json b/integration/helpers/vite-template/package.json
@@ -36,6 +36,6 @@
     "vite-tsconfig-paths": "^4.2.1"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   }
 }
diff --git a/package.json b/package.json
@@ -122,7 +122,7 @@
     "vite-tsconfig-paths": "^4.2.2"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   },
   "pnpm": {
     "patchedDependencies": {
diff --git a/packages/react-router-architect/package.json b/packages/react-router-architect/package.json
@@ -48,7 +48,7 @@
     }
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   },
   "files": [
     "dist/",
diff --git a/packages/react-router-cloudflare/package.json b/packages/react-router-cloudflare/package.json
@@ -40,7 +40,7 @@
     }
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   },
   "files": [
     "dist/",
diff --git a/packages/react-router-dev/__tests__/fixtures/node/package.json b/packages/react-router-dev/__tests__/fixtures/node/package.json
@@ -24,6 +24,6 @@
     "typescript": "^5.1.6"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   }
 }
diff --git a/packages/react-router-dev/cli/run.ts b/packages/react-router-dev/cli/run.ts
@@ -81,9 +81,15 @@ ${colors.logoBlue("react-router")}
 export async function run(argv: string[] = process.argv.slice(2)) {
   // Check the node version
   let versions = process.versions;
-  if (versions && versions.node && semver.major(versions.node) < 18) {
+  let MINIMUM_NODE_VERSION = 20;
+  if (
+    versions &&
+    versions.node &&
+    semver.major(versions.node) < MINIMUM_NODE_VERSION
+  ) {
     throw new Error(
-      `️🚨 Oops, Node v${versions.node} detected. react-router requires a Node version greater than 18.`
+      `️🚨 Oops, Node v${versions.node} detected. react-router requires ` +
+        `a Node version greater than ${MINIMUM_NODE_VERSION}.`
     );
   }
 
diff --git a/packages/react-router-dev/package.json b/packages/react-router-dev/package.json
@@ -112,7 +112,7 @@
     }
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   },
   "files": [
     "dist/",
diff --git a/packages/react-router-dom/package.json b/packages/react-router-dom/package.json
@@ -47,6 +47,6 @@
     "README.md"
   ],
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   }
 }
diff --git a/packages/react-router-express/package.json b/packages/react-router-express/package.json
@@ -46,7 +46,7 @@
     }
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   },
   "files": [
     "dist/",
diff --git a/packages/react-router-fs-routes/package.json b/packages/react-router-fs-routes/package.json
@@ -40,7 +40,7 @@
     }
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   },
   "files": [
     "dist/",
diff --git a/packages/react-router-node/package.json b/packages/react-router-node/package.json
@@ -48,7 +48,7 @@
     }
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   },
   "files": [
     "dist/",
diff --git a/packages/react-router-remix-config-routes-adapter/package.json b/packages/react-router-remix-config-routes-adapter/package.json
@@ -37,7 +37,7 @@
     }
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   },
   "files": [
     "dist/",
diff --git a/packages/react-router-serve/package.json b/packages/react-router-serve/package.json
@@ -39,7 +39,7 @@
     "@types/source-map-support": "^0.5.6"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   },
   "files": [
     "dist/",
diff --git a/packages/react-router/__tests__/router/navigation-test.ts b/packages/react-router/__tests__/router/navigation-test.ts
@@ -171,11 +171,11 @@ describe("navigations", () => {
       );
       expect(t.router.state.loaderData).toEqual({});
 
-      // Node 16/18 versus 20 output different errors here :/
-      let expected = process.version.startsWith("v18")
-        ? "Unexpected token } in JSON at position 15"
-        : "Unexpected non-whitespace character after JSON at position 15";
-      expect(t.router.state.errors?.foo).toEqual(new SyntaxError(expected));
+      expect(t.router.state.errors?.foo).toEqual(
+        new SyntaxError(
+          "Unexpected non-whitespace character after JSON at position 15"
+        )
+      );
     });
 
     it("bubbles errors when unwrapping Responses", async () => {
@@ -207,11 +207,11 @@ describe("navigations", () => {
       );
       expect(t.router.state.loaderData).toEqual({});
 
-      // Node 16/18 versus 20 output different errors here :/
-      let expected = process.version.startsWith("v18")
-        ? "Unexpected token } in JSON at position 15"
-        : "Unexpected non-whitespace character after JSON at position 15";
-      expect(t.router.state.errors?.root).toEqual(new SyntaxError(expected));
+      expect(t.router.state.errors?.root).toEqual(
+        new SyntaxError(
+          "Unexpected non-whitespace character after JSON at position 15"
+        )
+      );
     });
 
     it("does not fetch unchanging layout data", async () => {
diff --git a/packages/react-router/__tests__/router/ssr-test.ts b/packages/react-router/__tests__/router/ssr-test.ts
@@ -753,9 +753,6 @@ describe("ssr", () => {
       let e;
       try {
         let contextPromise = query(request);
-        // Note this works in Node 18+ - but it does not work if using the
-        // `abort-controller` polyfill which doesn't yet support a custom `reason`
-        // See: https://github.com/mysticatea/abort-controller/issues/33
         controller.abort(new Error("Oh no!"));
         // This should resolve even though we never resolved the loader
         await contextPromise;
@@ -2082,9 +2079,6 @@ describe("ssr", () => {
       let e;
       try {
         let statePromise = queryRoute(request, { routeId: "root" });
-        // Note this works in Node 18+ - but it does not work if using the
-        // `abort-controller` polyfill which doesn't yet support a custom `reason`
-        // See: https://github.com/mysticatea/abort-controller/issues/33
         controller.abort(new Error("Oh no!"));
         // This should resolve even though we never resolved the loader
         await statePromise;
diff --git a/packages/react-router/package.json b/packages/react-router/package.json
@@ -68,6 +68,6 @@
     "README.md"
   ],
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   }
 }
diff --git a/playground/compiler-express/package.json b/playground/compiler-express/package.json
@@ -34,6 +34,6 @@
     "vite-tsconfig-paths": "^4.2.1"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   }
 }
diff --git a/playground/compiler-spa/package.json b/playground/compiler-spa/package.json
@@ -25,6 +25,6 @@
     "vite-tsconfig-paths": "^4.2.1"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   }
 }
diff --git a/playground/compiler/package.json b/playground/compiler/package.json
@@ -27,6 +27,6 @@
     "vite-tsconfig-paths": "^4.2.1"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   }
 }
diff --git a/rollup.utils.js b/rollup.utils.js
@@ -143,7 +143,7 @@ function isBareModuleId(id) {
 
 const remixBabelConfig = {
   presets: [
-    ["@babel/preset-env", { targets: { node: "18" } }],
+    ["@babel/preset-env", { targets: { node: "20" } }],
     "@babel/preset-react",
     "@babel/preset-typescript",
   ],

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,6 @@`
`34`	`34`	`"typescript": "^5.1.0"`
`35`	`35`	`},`
`36`	`36`	`"engines": {`
`37`		`- "node": ">=18.0.0"`
	`37`	`+ "node": ">=20.0.0"`
`38`	`38`	`}`
`39`	`39`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,6 @@`
`30`	`30`	`"wrangler": "^3.28.2"`
`31`	`31`	`},`
`32`	`32`	`"engines": {`
`33`		`- "node": ">=18.0.0"`
	`33`	`+ "node": ">=20.0.0"`
`34`	`34`	`}`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,6 @@`
`36`	`36`	`"vite-tsconfig-paths": "^4.2.1"`
`37`	`37`	`},`
`38`	`38`	`"engines": {`
`39`		`- "node": ">=18.0.0"`
	`39`	`+ "node": ">=20.0.0"`
`40`	`40`	`}`
`41`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@`
`48`	`48`	`}`
`49`	`49`	`},`
`50`	`50`	`"engines": {`
`51`		`- "node": ">=18.0.0"`
	`51`	`+ "node": ">=20.0.0"`
`52`	`52`	`},`
`53`	`53`	`"files": [`
`54`	`54`	`"dist/",`