Mark reveal as unsupported in RSC Framework Mode (#14289)

Author: markdalgleish

packages/react-router-dev/cli/commands.ts

@@ -16,6 +16,7 @@ import { transpile as convertFileToJS } from "./useJavascript";
 import * as profiler from "../vite/profiler";
 import * as Typegen from "../typegen";
 import { preloadVite, getVite } from "../vite/vite";
+import { hasReactRouterRscPlugin } from "../vite/has-rsc-plugin";
 
 export async function routes(
   rootDirectory?: string,
@@ -89,14 +90,32 @@ export async function generateEntry(
     mode?: string;
   } = {},
 ) {
+  rootDirectory = resolveRootDirectory(rootDirectory, flags);
+
+  if (
+    await hasReactRouterRscPlugin({
+      root: rootDirectory,
+      viteBuildOptions: {
+        config: flags.config,
+        mode: flags.mode,
+      },
+    })
+  ) {
+    console.error(
+      colors.red(
+        `The reveal command is currently not supported in RSC Framework Mode.`,
+      ),
+    );
+    process.exit(1);
+  }
+
   // if no entry passed, attempt to create both
   if (!entry) {
     await generateEntry("entry.client", rootDirectory, flags);
     await generateEntry("entry.server", rootDirectory, flags);
     return;
   }
 
-  rootDirectory = resolveRootDirectory(rootDirectory, flags);
   let configResult = await loadConfig({
     rootDirectory,
     mode: flags.mode ?? "production",

packages/react-router-dev/vite/build.ts

@@ -15,6 +15,7 @@ import {
 } from "./plugin";
 import invariant from "../invariant";
 import { preloadVite, getVite } from "./vite";
+import { hasReactRouterRscPlugin } from "./has-rsc-plugin";
 export interface ViteBuildOptions {
   assetsInlineLimit?: number;
   clearScreen?: boolean;
@@ -234,27 +235,3 @@ async function viteBuild(
     viteConfig,
   });
 }
-
-async function hasReactRouterRscPlugin({
-  root,
-  viteBuildOptions: { config, logLevel, mode },
-}: {
-  root: string;
-  viteBuildOptions: ViteBuildOptions;
-}): Promise<boolean> {
-  const vite = await import("vite");
-  const viteConfig = await vite.resolveConfig(
-    {
-      configFile: config,
-      logLevel,
-      mode: mode ?? "production",
-      root,
-    },
-    "build", // command
-    "production", // default mode
-    "production", // default NODE_ENV
-  );
-  return viteConfig.plugins.some(
-    (plugin) => plugin?.name === "react-router/rsc",
-  );
-}

packages/react-router-dev/vite/has-rsc-plugin.ts

@@ -0,0 +1,29 @@
+import type * as Vite from "vite";
+
+export async function hasReactRouterRscPlugin({
+  root,
+  viteBuildOptions: { config, logLevel, mode },
+}: {
+  root: string;
+  viteBuildOptions: {
+    config?: string;
+    logLevel?: Vite.LogLevel;
+    mode?: string;
+  };
+}): Promise<boolean> {
+  const vite = await import("vite");
+  const viteConfig = await vite.resolveConfig(
+    {
+      configFile: config,
+      logLevel,
+      mode: mode ?? "production",
+      root,
+    },
+    "build", // command
+    "production", // default mode
+    "production", // default NODE_ENV
+  );
+  return viteConfig.plugins.some(
+    (plugin) => plugin?.name === "react-router/rsc",
+  );
+}