allow spa redirects to same origin

Author: jacob-ebey

packages/react-router/lib/rsc/browser.tsx

@@ -140,7 +140,7 @@ export function createCallServer({
       Promise.resolve(payloadPromise)
         .then(async (payload) => {
           if (payload.type === "redirect") {
-            if (payload.reload) {
+            if (payload.reload || isExternalLocation(payload.location)) {
               window.location.href = payload.location;
               return () => {};
             }
@@ -163,7 +163,7 @@ export function createCallServer({
             globalVar.__routerActionID <= actionId
           ) {
             if (rerender.type === "redirect") {
-              if (rerender.reload) {
+              if (rerender.reload || isExternalLocation(rerender.location)) {
                 window.location.href = rerender.location;
                 return;
               }
@@ -1047,3 +1047,8 @@ function debounce(callback: (...args: unknown[]) => unknown, wait: number) {
     timeoutId = window.setTimeout(() => callback(...args), wait);
   };
 }
+
+function isExternalLocation(location: string) {
+  const newLocation = new URL(location, window.location.href);
+  return newLocation.origin !== window.location.origin;
+}

packages/react-router/lib/rsc/server.rsc.ts

@@ -887,13 +887,10 @@ function generateRedirectResponse(
     redirect = stripBasename(redirect, basename) || redirect;
   }
 
-  const isExternal = isAbsoluteUrl(redirect);
-
   let payload: RSCRedirectPayload = {
     type: "redirect",
     location: redirect,
-    reload:
-      isExternal || response.headers.get("X-Remix-Reload-Document") === "true",
+    reload: response.headers.get("X-Remix-Reload-Document") === "true",
     replace: response.headers.get("X-Remix-Replace") === "true",
     status: response.status,
     actionResult,