Skip to content

Commit ee0f2ee

Browse files
committed
Bump rolldown-vite, simplify test Rolldown detection
1 parent 0f1fe35 commit ee0f2ee

File tree

4 files changed

+85
-98
lines changed

4 files changed

+85
-98
lines changed

integration/helpers/vite-rolldown-template/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@
3131
"@types/react-dom": "^18.2.7",
3232
"eslint": "^8.38.0",
3333
"typescript": "^5.1.6",
34-
"vite": "npm:[email protected].3",
34+
"vite": "npm:[email protected].5",
3535
"vite-env-only": "^3.0.1",
3636
"vite-tsconfig-paths": "^4.2.1"
3737
},
3838
"overrides": {
39-
"vite": "npm:[email protected].3"
39+
"vite": "npm:[email protected].5"
4040
},
4141
"engines": {
4242
"node": ">=20.0.0"

integration/helpers/vite.ts

Lines changed: 12 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -99,31 +99,18 @@ export const viteConfig = {
9999
build: ({ assetsInlineLimit, assetsDir }: ViteConfigBuildArgs = {}) => {
100100
return dedent`
101101
build: {
102-
rollupOptions: await (async () => {
103-
const fs = await import("node:fs/promises");
104-
const path = await import("node:path");
105-
const vitePackageJsonPath = path.join(import.meta.dirname, "node_modules/vite/package.json");
106-
const vitePackageJson = JSON.parse(await fs.readFile(vitePackageJsonPath, "utf8"));
107-
const isRolldown = vitePackageJson.name === "rolldown-vite";
108-
109-
return isRolldown ? {
110-
// NOTE: ignore "The built-in minifier is still under development." warning
111-
onwarn(warning, warn) {
112-
if (warning.code === "MINIFY_WARNING") return;
113-
warn(warning);
114-
},
115-
} : undefined;
116-
})(),
117-
${
118-
assetsInlineLimit !== undefined
119-
? `assetsInlineLimit: ${JSON.stringify(assetsInlineLimit)},`
120-
: ""
121-
}
122-
${
123-
assetsDir !== undefined
124-
? `assetsDir: ${JSON.stringify(assetsDir)},`
125-
: ""
126-
}
102+
// Detect rolldown-vite:
103+
rollupOptions: "transformWithOxc" in (await import("vite"))
104+
? {
105+
onwarn(warning, warn) {
106+
// Ignore "The built-in minifier is still under development." warning
107+
if (warning.code === "MINIFY_WARNING") return;
108+
warn(warning);
109+
},
110+
}
111+
: undefined,
112+
assetsInlineLimit: ${assetsInlineLimit ?? "undefined"},
113+
assetsDir: ${assetsDir ?? "undefined"},
127114
},
128115
`;
129116
},

playground/framework-rolldown-vite/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@
2323
"@types/react": "^18.2.20",
2424
"@types/react-dom": "^18.2.7",
2525
"typescript": "^5.1.6",
26-
"vite": "npm:[email protected].3",
26+
"vite": "npm:[email protected].5",
2727
"vite-tsconfig-paths": "^4.2.1"
2828
},
2929
"overrides": {
30-
"vite": "npm:[email protected].3"
30+
"vite": "npm:[email protected].5"
3131
},
3232
"engines": {
3333
"node": ">=20.0.0"

pnpm-lock.yaml

Lines changed: 69 additions & 69 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)