Skip to content

Commit eed8ce7

Browse files
chaancechaance
committed
add strictness for test types
1 parent a0db8bf commit eed8ce7

29 files changed

+160
-135
lines changed

‎packages/react-router-dom/__tests__/exports-test.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import * as ReactRouterDOM from "react-router-dom";
44
describe("react-router-dom", () => {
55
for (let key in ReactRouter) {
66
it(`re-exports ${key} from react-router`, () => {
7+
// @ts-ignore
78
expect(ReactRouterDOM[key]).toBe(ReactRouter[key]);
89
});
910
}

‎packages/react-router-dom/__tests__/link-click-test.tsx

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ describe("A <Link> click", () => {
1212

1313
afterEach(() => {
1414
document.body.removeChild(node);
15-
node = null;
15+
node = null!;
1616
});
1717

1818
it("navigates to the new page", () => {
@@ -45,7 +45,7 @@ describe("A <Link> click", () => {
4545
expect(anchor).not.toBeNull();
4646

4747
act(() => {
48-
anchor.dispatchEvent(
48+
anchor?.dispatchEvent(
4949
new MouseEvent("click", {
5050
view: window,
5151
bubbles: true,
@@ -56,7 +56,7 @@ describe("A <Link> click", () => {
5656

5757
let h1 = node.querySelector("h1");
5858
expect(h1).not.toBeNull();
59-
expect(h1.textContent).toEqual("About");
59+
expect(h1?.textContent).toEqual("About");
6060
});
6161

6262
describe("when preventDefault is used on the click handler", () => {
@@ -96,7 +96,7 @@ describe("A <Link> click", () => {
9696
expect(anchor).not.toBeNull();
9797

9898
act(() => {
99-
anchor.dispatchEvent(
99+
anchor?.dispatchEvent(
100100
new MouseEvent("click", {
101101
view: window,
102102
bubbles: true,
@@ -107,7 +107,7 @@ describe("A <Link> click", () => {
107107

108108
let h1 = node.querySelector("h1");
109109
expect(h1).not.toBeNull();
110-
expect(h1.textContent).toEqual("Home");
110+
expect(h1?.textContent).toEqual("Home");
111111
});
112112
});
113113

@@ -144,7 +144,7 @@ describe("A <Link> click", () => {
144144
act(() => {
145145
// https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/button
146146
let RightMouseButton = 2;
147-
anchor.dispatchEvent(
147+
anchor?.dispatchEvent(
148148
new MouseEvent("click", {
149149
view: window,
150150
bubbles: true,
@@ -156,7 +156,7 @@ describe("A <Link> click", () => {
156156

157157
let h1 = node.querySelector("h1");
158158
expect(h1).not.toBeNull();
159-
expect(h1.textContent).toEqual("Home");
159+
expect(h1?.textContent).toEqual("Home");
160160
});
161161
});
162162

@@ -193,7 +193,7 @@ describe("A <Link> click", () => {
193193
expect(anchor).not.toBeNull();
194194

195195
act(() => {
196-
anchor.dispatchEvent(
196+
anchor?.dispatchEvent(
197197
new MouseEvent("click", {
198198
view: window,
199199
bubbles: true,
@@ -204,7 +204,7 @@ describe("A <Link> click", () => {
204204

205205
let h1 = node.querySelector("h1");
206206
expect(h1).not.toBeNull();
207-
expect(h1.textContent).toEqual("Home");
207+
expect(h1?.textContent).toEqual("Home");
208208
});
209209
});
210210

@@ -239,7 +239,7 @@ describe("A <Link> click", () => {
239239
expect(anchor).not.toBeNull();
240240

241241
act(() => {
242-
anchor.dispatchEvent(
242+
anchor?.dispatchEvent(
243243
new MouseEvent("click", {
244244
view: window,
245245
bubbles: true,
@@ -252,7 +252,7 @@ describe("A <Link> click", () => {
252252

253253
let h1 = node.querySelector("h1");
254254
expect(h1).not.toBeNull();
255-
expect(h1.textContent).toEqual("Home");
255+
expect(h1?.textContent).toEqual("Home");
256256
});
257257
});
258258
});

‎packages/react-router-dom/__tests__/link-href-test.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ describe("Link href", () => {
1515
);
1616
}
1717

18-
let renderer: ReactTestRenderer;
18+
let renderer!: ReactTestRenderer;
1919
act(() => {
2020
renderer = createTestRenderer(
2121
<Router initialEntries={["/home"]}>
@@ -44,7 +44,7 @@ describe("Link href", () => {
4444
);
4545
}
4646

47-
let renderer: ReactTestRenderer;
47+
let renderer!: ReactTestRenderer;
4848
act(() => {
4949
renderer = createTestRenderer(
5050
<Router initialEntries={["/home"]}>
@@ -73,7 +73,7 @@ describe("Link href", () => {
7373
);
7474
}
7575

76-
let renderer: ReactTestRenderer;
76+
let renderer!: ReactTestRenderer;
7777
act(() => {
7878
renderer = createTestRenderer(
7979
<Router initialEntries={["/home"]}>
@@ -102,7 +102,7 @@ describe("Link href", () => {
102102
);
103103
}
104104

105-
let renderer: ReactTestRenderer;
105+
let renderer!: ReactTestRenderer;
106106
act(() => {
107107
renderer = createTestRenderer(
108108
<Router initialEntries={["/home"]}>
@@ -131,7 +131,7 @@ describe("Link href", () => {
131131
);
132132
}
133133

134-
let renderer: ReactTestRenderer;
134+
let renderer!: ReactTestRenderer;
135135
act(() => {
136136
renderer = createTestRenderer(
137137
<Router initialEntries={["/app/home"]}>

‎packages/react-router-dom/__tests__/link-push-test.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ describe("Link push and replace", () => {
3737

3838
afterEach(() => {
3939
document.body.removeChild(node);
40-
node = null;
40+
node = null!;
4141
});
4242

4343
describe("to a different pathname, when it is clicked", () => {
@@ -73,7 +73,7 @@ describe("Link push and replace", () => {
7373
expect(anchor).not.toBeNull();
7474

7575
act(() => {
76-
anchor.dispatchEvent(
76+
anchor?.dispatchEvent(
7777
new MouseEvent("click", {
7878
view: window,
7979
bubbles: true,
@@ -126,7 +126,7 @@ describe("Link push and replace", () => {
126126
expect(anchor).not.toBeNull();
127127

128128
act(() => {
129-
anchor.dispatchEvent(
129+
anchor?.dispatchEvent(
130130
new MouseEvent("click", {
131131
view: window,
132132
bubbles: true,
@@ -179,7 +179,7 @@ describe("Link push and replace", () => {
179179
expect(anchor).not.toBeNull();
180180

181181
act(() => {
182-
anchor.dispatchEvent(
182+
anchor?.dispatchEvent(
183183
new MouseEvent("click", {
184184
view: window,
185185
bubbles: true,
@@ -237,7 +237,7 @@ describe("Link push and replace", () => {
237237
expect(anchor).not.toBeNull();
238238

239239
act(() => {
240-
anchor.dispatchEvent(
240+
anchor?.dispatchEvent(
241241
new MouseEvent("click", {
242242
view: window,
243243
bubbles: true,

‎packages/react-router-dom/__tests__/nav-link-active-test.tsx

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe("NavLink", () => {
2121
);
2222
}
2323

24-
let renderer: ReactTestRenderer;
24+
let renderer!: ReactTestRenderer;
2525
act(() => {
2626
renderer = createTestRenderer(
2727
<Router initialEntries={["/home"]}>
@@ -52,7 +52,7 @@ describe("NavLink", () => {
5252
);
5353
}
5454

55-
let renderer: ReactTestRenderer;
55+
let renderer!: ReactTestRenderer;
5656
act(() => {
5757
renderer = createTestRenderer(
5858
<Router initialEntries={["/home"]}>
@@ -84,7 +84,7 @@ describe("NavLink", () => {
8484
);
8585
}
8686

87-
let renderer: ReactTestRenderer;
87+
let renderer!: ReactTestRenderer;
8888
act(() => {
8989
renderer = createTestRenderer(
9090
<Router initialEntries={["/home"]}>
@@ -112,7 +112,7 @@ describe("NavLink", () => {
112112
);
113113
}
114114

115-
let renderer: ReactTestRenderer;
115+
let renderer!: ReactTestRenderer;
116116
act(() => {
117117
renderer = createTestRenderer(
118118
<Router initialEntries={["/home"]}>
@@ -147,7 +147,7 @@ describe("NavLink", () => {
147147
return <div>Child</div>;
148148
}
149149

150-
let renderer: ReactTestRenderer;
150+
let renderer!: ReactTestRenderer;
151151
act(() => {
152152
renderer = createTestRenderer(
153153
<Router initialEntries={["/home/child"]}>
@@ -181,7 +181,7 @@ describe("NavLink", () => {
181181
return <div>Child</div>;
182182
}
183183

184-
let renderer: ReactTestRenderer;
184+
let renderer!: ReactTestRenderer;
185185
act(() => {
186186
renderer = createTestRenderer(
187187
<Router initialEntries={["/home/child"]}>
@@ -219,7 +219,7 @@ describe("NavLink", () => {
219219
return <div>Child</div>;
220220
}
221221

222-
let renderer: ReactTestRenderer;
222+
let renderer!: ReactTestRenderer;
223223
act(() => {
224224
renderer = createTestRenderer(
225225
<Router initialEntries={["/home/child"]}>
@@ -257,7 +257,7 @@ describe("NavLink", () => {
257257
return <div>Child</div>;
258258
}
259259

260-
let renderer: ReactTestRenderer;
260+
let renderer!: ReactTestRenderer;
261261
act(() => {
262262
renderer = createTestRenderer(
263263
<Router initialEntries={["/home/child"]}>
@@ -293,7 +293,7 @@ describe("NavLink", () => {
293293
);
294294
}
295295

296-
let renderer: ReactTestRenderer;
296+
let renderer!: ReactTestRenderer;
297297
act(() => {
298298
renderer = createTestRenderer(
299299
<Router initialEntries={["/Home"]}>
@@ -321,7 +321,7 @@ describe("NavLink", () => {
321321
);
322322
}
323323

324-
let renderer: ReactTestRenderer;
324+
let renderer!: ReactTestRenderer;
325325
act(() => {
326326
renderer = createTestRenderer(
327327
<Router initialEntries={["/Home"]}>
@@ -353,7 +353,7 @@ describe("NavLink", () => {
353353
);
354354
}
355355

356-
let renderer: ReactTestRenderer;
356+
let renderer!: ReactTestRenderer;
357357
act(() => {
358358
renderer = createTestRenderer(
359359
<Router initialEntries={["/Home"]}>
@@ -385,7 +385,7 @@ describe("NavLink", () => {
385385
);
386386
}
387387

388-
let renderer: ReactTestRenderer;
388+
let renderer!: ReactTestRenderer;
389389
act(() => {
390390
renderer = createTestRenderer(
391391
<Router initialEntries={["/Home"]}>
@@ -420,7 +420,7 @@ describe("NavLink under a Routes with a basename", () => {
420420
);
421421
}
422422

423-
let renderer: ReactTestRenderer;
423+
let renderer!: ReactTestRenderer;
424424
act(() => {
425425
renderer = createTestRenderer(
426426
<Router initialEntries={["/app/home"]}>
@@ -451,7 +451,7 @@ describe("NavLink under a Routes with a basename", () => {
451451
);
452452
}
453453

454-
let renderer: ReactTestRenderer;
454+
let renderer!: ReactTestRenderer;
455455
act(() => {
456456
renderer = createTestRenderer(
457457
<Router initialEntries={["/app/home"]}>
@@ -483,7 +483,7 @@ describe("NavLink under a Routes with a basename", () => {
483483
);
484484
}
485485

486-
let renderer: ReactTestRenderer;
486+
let renderer!: ReactTestRenderer;
487487
act(() => {
488488
renderer = createTestRenderer(
489489
<Router initialEntries={["/app/home"]}>
@@ -511,7 +511,7 @@ describe("NavLink under a Routes with a basename", () => {
511511
);
512512
}
513513

514-
let renderer: ReactTestRenderer;
514+
let renderer!: ReactTestRenderer;
515515
act(() => {
516516
renderer = createTestRenderer(
517517
<Router initialEntries={["/app/home"]}>

‎packages/react-router-dom/__tests__/navigate-encode-params-test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe("navigate with params", () => {
1818

1919
afterEach(() => {
2020
document.body.removeChild(node);
21-
node = null;
21+
node = null!;
2222
});
2323

2424
describe("when navigate params are not already encoded", () => {

‎packages/react-router-dom/__tests__/search-params-test.tsx

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,20 @@ import {
1010

1111
describe("useSearchParams", () => {
1212
function SearchPage() {
13-
let queryRef = React.useRef<HTMLInputElement>();
13+
let queryRef = React.useRef<HTMLInputElement>(null);
1414
let [searchParams, setSearchParams] = useSearchParams({ q: "" });
15-
let query = searchParams.get("q");
15+
let query = searchParams.get("q")!;
1616

1717
function handleSubmit(event: React.FormEvent<HTMLFormElement>) {
1818
event.preventDefault();
19-
setSearchParams({ q: queryRef.current.value });
19+
if (queryRef.current) {
20+
setSearchParams({ q: queryRef.current.value });
21+
}
2022
}
2123

2224
return (
2325
<div>
2426
<p>The current query is "{query}".</p>
25-
2627
<form onSubmit={handleSubmit}>
2728
<input name="q" defaultValue={query} ref={queryRef} />
2829
</form>
@@ -38,7 +39,7 @@ describe("useSearchParams", () => {
3839

3940
afterEach(() => {
4041
document.body.removeChild(node);
41-
node = null;
42+
node = null!;
4243
});
4344

4445
it("reads and writes the search string", () => {
@@ -53,10 +54,10 @@ describe("useSearchParams", () => {
5354
);
5455
});
5556

56-
let form = node.querySelector("form");
57+
let form = node.querySelector("form")!;
5758
expect(form).toBeDefined();
5859

59-
let queryInput = node.querySelector<HTMLInputElement>("input[name=q]");
60+
let queryInput = node.querySelector<HTMLInputElement>("input[name=q]")!;
6061
expect(queryInput).toBeDefined();
6162

6263
expect(node.innerHTML).toMatch(/The current query is "Michael Jackson"/);

0 commit comments

Comments
 (0)