Skip to content

Commit fbe796a

Browse files
authored
docs: refresh contributing bug section (#13143)
* docs: refresh contributing bug section * sign SLA
1 parent 0c36a70 commit fbe796a

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

contributors.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@
231231
- mspiess
232232
- mtendekuyokwa19
233233
- mtliendo
234+
- namoscato
234235
- ned-park
235236
- nikeee
236237
- nilubisan

docs/community/contributing.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,20 @@ The following steps will get you set up to contribute changes to this repo:
2020
1. Fork the repo (click the <kbd>Fork</kbd> button at the top right of [this page](https://github.com/remix-run/react-router))
2121
2. Clone your fork locally
2222

23-
```bash
24-
# in a terminal, cd to parent directory where you want your clone to be, then
25-
git clone https://github.com/<your_github_username>/react-router.git
26-
cd react-router
23+
```bash
24+
# in a terminal, cd to parent directory where you want your clone to be, then
25+
git clone https://github.com/<your_github_username>/react-router.git
26+
cd react-router
2727

28-
# if you are making *any* code changes, make sure to checkout the dev branch
29-
git checkout dev
30-
```
28+
# if you are making *any* code changes, make sure to checkout the dev branch
29+
git checkout dev
30+
```
3131

3232
3. Install dependencies and build. React Router uses [pnpm](https://pnpm.io), so you should too. If you install using `npm`, unnecessary `package-lock.json` files will be generated.
3333

3434
## Think You Found a Bug?
3535

36-
Please conform to the issue template and provide a clear path to reproduction with a code example. Best is a pull request with a failing test. Next best is a link to CodeSandbox or repository that illustrates the bug.
36+
Please conform to the issue template and provide a clear path to reproduction with a code example. Best is a pull request with a [failing test](https://github.com/remix-run/react-router/blob/dev/integration/bug-report-test.ts). Next best is a link to [StackBlitz](https://reactrouter.com/new) or repository that illustrates the bug.
3737

3838
## Adding an Example?
3939

@@ -59,7 +59,7 @@ Pull requests need only the approval of two or more collaborators to be merged;
5959

6060
All commits that fix bugs or add features need a test.
6161

62-
`<blink>`Do not merge code without tests!`</blink>`
62+
<docs-error>Do not merge code without tests!</docs-error>
6363

6464
### Docs + Examples
6565

0 commit comments

Comments
 (0)