Replies: 2 comments 6 replies
-
I’m currently patching |
Beta Was this translation helpful? Give feedback.
5 replies
-
Hey folks! We added a new |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hello Devs,
Description
This is sort of a follow up on #12418. Though to be clear, this proposal is for sites that don't have basePaths. We have multiple root level frontend applications that manage a collection of root based routes.
For Example:
/
/help
/search
/contact-us
The Problem
With Lazy Route Disovery the fact that the
/__manifest
queries will go to the root or "basename" of the ReactRouter App doesn't suit this routing model. As our Frontend App 2 manifest requests will be recieved by the Frontend App 1.The Proposal
The proposal/request is that ReactRouter applications can support custom defined
__manifest
paths via thereact-router.config.ts
file.This could either be an exising route known to the app e.g.
/help/__manifest
Where even the/contact-us
page will still request via/help/__manifest
or a custom defined path that is then consumed as a new route within the app.So for
/site/app2/__manifest
aRoute('site/app2')
would additonally be added at build. Then both/help
and/contact-us
would query/site/app2/__manifest
.Expectations:
/site/app2
) to return a 404 as an "unregistered" route.manifestPath
to take priority over thebasePath
when generating the manifest url.Example
Produces manifest url =
${hostname}/site/app/__manifest
Beta Was this translation helpful? Give feedback.
All reactions