-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Closed
Labels
Description
I'm using React Router as a...
framework
Reproduction
see below
System Info
System:
OS: macOS 15.3.1
CPU: (8) arm64 Apple M2
Memory: 150.70 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 22.12.0 - ~/.local/state/fnm_multishells/93155_1741110880467/bin/node
npm: 10.9.0 - ~/.local/state/fnm_multishells/93155_1741110880467/bin/npm
pnpm: 10.5.2 - ~/Library/pnpm/pnpm
Browsers:
Chrome: 133.0.6943.142
Safari: 18.3
npmPackages:
@react-router/cloudflare: ^7.3.0-pre.0 => 7.3.0-pre.0
@react-router/dev: ^7.3.0-pre.0 => 7.3.0-pre.0
@react-router/fs-routes: ^7.3.0-pre.0 => 7.3.0-pre.0
react-router: ^7.3.0-pre.0 => 7.3.0-pre.0
vite: ^6.2.0 => 6.2.0Used Package Manager
pnpm
Expected Behavior
The request handler type should be unstable_InitialContext instead of unstable_RouterContextProvider
react-router/packages/react-router/lib/server-runtime/server.ts
Lines 41 to 46 in 5f6b341
| export type RequestHandler = ( | |
| request: Request, | |
| loadContext?: MiddlewareEnabled extends true | |
| ? unstable_RouterContextProvider | |
| : AppLoadContext | |
| ) => Promise<Response>; |
see usage
react-router/packages/react-router/lib/server-runtime/server.ts
Lines 90 to 97 in 5f6b341
| return async function requestHandler(request, initialContext) { | |
| _build = typeof build === "function" ? await build() : build; | |
| let loadContext = _build.future.unstable_middleware | |
| ? new unstable_RouterContextProvider( | |
| initialContext as unknown as unstable_InitialContext | |
| ) | |
| : initialContext || {}; |
Actual Behavior
see description