Update to RR 7.4.0 Borked

[keepforever]

I'm using React Router as a...

Framework

Reproduction

npx npm-check-updates --reject "vite, typescript" -u
npm install

System Info

node

Used Package Manager

npm

Expected Behavior

I expect to not have to drop my package.json every time RR upgrades

Actual Behavior

npx npm-check-updates --reject "vite, typescript" -u

Upgrading /Users/briancilenti/Desktop/projects/studio2/package.json
[====================] 66/66 100%

@clerk/react-router ^1.1.5 → ^1.1.6
@react-router/dev ^7.3.0 → ^7.4.0
@react-router/node ^7.3.0 → ^7.4.0
@react-router/serve ^7.3.0 → ^7.4.0
@tvadsai/control-room ^0.338.3 → ^0.338.4
@tvadsai/shopify-api ^0.338.3 → ^0.338.4
@types/react ^19.0.11 → ^19.0.12
react-router ^7.3.0 → ^7.4.0

Run npm install to install new versions.
studio2 [ctrl-room-4●] ni
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: studio-2@undefined
npm error Found: @react-router/dev@7.3.0
npm error node_modules/@react-router/dev
npm error dev @react-router/dev@"^7.4.0" from the root project
npm error
npm error Could not resolve dependency:
npm error dev @react-router/dev@"^7.4.0" from the root project
npm error
npm error Conflicting peer dependency: react-router@7.4.0
npm error node_modules/react-router
npm error peer react-router@"^7.4.0" from @react-router/dev@7.4.0
npm error node_modules/@react-router/dev
npm error dev @react-router/dev@"^7.4.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /Users/briancilenti/.npm/_logs/2025-03-19T17_27_21_214Z-eresolve-report.txt
npm error A complete log of this run can be found in: /Users/briancilenti/.npm/_logs/2025-03-19T17_27_21_214Z-debug-0.log

[keepforever]

The fix here is to delete node_modules and package-lock.json and do a clean install, but, I have to imagine there's something internally wrong with react-router because this happened on the last minor version bump as well

[firxworx]

I had an issue with 7.4.0 too but will file a new issue because even blowing away node_modules and pnpm lockfile in my case did nothing.

[timdorr]

I would run npm update instead of just install, as that will get any transient deps updated as well. But regardless of that, this doesn't have anything to do with the library or its packages. I use ncu as well and didn't encounter any problems updating 7.3.0 to 7.4.0

[AlastairSmith21]

@timdorr while npm update does "work" in a way, I agree with @keepforever's point that something seems off in the way the react router dependencies work with one another.

If you have the packages on a specific version, say "^7.1.5" and try to update to any other version then I encounter the same issue as described above.

From the debug log it does seem to point to the way peer dependencies are specified

91 verbose stack Error: could not resolve
91 verbose stack     at PlaceDep.failPeerConflict (/<path to nvm>/.nvm/versions/node/v20.18.1/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/place-dep.js:503:25)
...
92 error code ERESOLVE
93 error ERESOLVE could not resolve

I'm on:
Node: 20.18.1
Npm: 10.8.2

Normally I'd expect to be able to do npm i of just version changes to React router dependencies without needing to update all the other dependencies.