⚠️ No Changeset found

Latest commit: 1929d95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Hi @cksal0805,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

I must be missing something, but this looks like it increases the size of the package?

Here's my build steps:

pnpm clean
pnpm i
pnpm build
cd packages/react-router-dev
pnpm pack
ls -l react-router-dev-7.7.1.tgz

I did those on the SHA prior to this branch and the HEAD of this branch:

# Ran on SHA e89ad301 (the one before this PR started)
-rw-r--r--  1 matt  staff  119321 Aug 14 12:13 react-router-dev-7.7.1.tgz

# Ran on SHA 1929d95b (this branch)
-rw-r--r--  1 matt  staff  137999 Aug 14 12:11 react-router-dev-7.7.1.tgz

Aren't we only using the utils we import from lodash, not the whole thing? So the full es-toolkit might be larger than those 4 individual utilities from lodash?

import pick from "lodash/pick";
import omit from "lodash/omit";
import cloneDeep from "lodash/cloneDeep";
import isEqual from "lodash/isEqual";

Closing because as noted in #14180 (comment) es-toolkit has a node_modules footprint twice the size of lodash so this PR makes things worse, not better.

If you're going to AI slop something, at-least spend some time making sure the description is correct. Not sure where the other 42 file changes are.