From ff40b8d5bfca5c3ab6f26e898cdd4bf3c14f7805 Mon Sep 17 00:00:00 2001 From: gchang12 Date: Mon, 3 Nov 2025 15:28:28 -0800 Subject: [PATCH 1/4] Added backticks to filename; removed extra 'then'. --- docs/start/framework/data-loading.md | 2 +- docs/start/framework/route-module.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/start/framework/data-loading.md b/docs/start/framework/data-loading.md index b35995ef1b..d2f16f27b1 100644 --- a/docs/start/framework/data-loading.md +++ b/docs/start/framework/data-loading.md @@ -106,7 +106,7 @@ export default function Product({ } ``` -The URLs to pre-render are specified in react-router.config.ts: +The URLs to pre-render are specified in `react-router.config.ts`: ```ts filename=react-router.config.ts import type { Config } from "@react-router/dev/config"; diff --git a/docs/start/framework/route-module.md b/docs/start/framework/route-module.md index 68ab03d4c9..03be009527 100644 --- a/docs/start/framework/route-module.md +++ b/docs/start/framework/route-module.md @@ -480,7 +480,7 @@ The meta of the last matching route is used, allowing you to override parent rou ## `shouldRevalidate` -In framework mode with SSR, route loaders are automatically revalidated after all navigations and form submissions (this is different from [Data Mode][data-mode-should-revalidate]). This enables middleware and loaders to share a request context and optimize in different ways than then they would be in Data Mode. +In framework mode with SSR, route loaders are automatically revalidated after all navigations and form submissions (this is different from [Data Mode][data-mode-should-revalidate]). This enables middleware and loaders to share a request context and optimize in different ways than they would be in Data Mode. Defining this function allows you to opt out of revalidation for a route loader for navigations and form submissions. From 9d1bd837345be37de857b53a8a730ff5f4226287 Mon Sep 17 00:00:00 2001 From: gchang12 Date: Mon, 3 Nov 2025 15:36:00 -0800 Subject: [PATCH 2/4] Minor wording change for grammatical correctness. --- docs/start/framework/route-module.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/start/framework/route-module.md b/docs/start/framework/route-module.md index 03be009527..bba3cb5db6 100644 --- a/docs/start/framework/route-module.md +++ b/docs/start/framework/route-module.md @@ -480,7 +480,7 @@ The meta of the last matching route is used, allowing you to override parent rou ## `shouldRevalidate` -In framework mode with SSR, route loaders are automatically revalidated after all navigations and form submissions (this is different from [Data Mode][data-mode-should-revalidate]). This enables middleware and loaders to share a request context and optimize in different ways than they would be in Data Mode. +In framework mode with SSR, route loaders are automatically revalidated after all navigations and form submissions (this is different from [Data Mode][data-mode-should-revalidate]). This enables middleware and loaders to share a request context and optimize in different ways than they would in Data Mode. Defining this function allows you to opt out of revalidation for a route loader for navigations and form submissions. From b57fac17e64b2f3866d821aa08fb739c2879d15f Mon Sep 17 00:00:00 2001 From: George Chang <59218296+gchang12@users.noreply.github.com> Date: Mon, 3 Nov 2025 15:41:37 -0800 Subject: [PATCH 3/4] Update contributors.yml Signed name on line #132 --- contributors.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/contributors.yml b/contributors.yml index 08dd3651a3..6291fdd730 100644 --- a/contributors.yml +++ b/contributors.yml @@ -129,6 +129,7 @@ - gaspard - gatzjames - gavriguy +- gchang12 - Geist5000 - GeoffKarnov - gesposito From b911a3968b381207c5f18d49d0c42009cdbd6209 Mon Sep 17 00:00:00 2001 From: gchang12 Date: Sat, 15 Nov 2025 14:35:03 -0800 Subject: [PATCH 4/4] TODO: Inspect this weird line containing the function, . --- docs/tutorials/address-book.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorials/address-book.md b/docs/tutorials/address-book.md index 3e356eb455..279bf44967 100644 --- a/docs/tutorials/address-book.md +++ b/docs/tutorials/address-book.md @@ -1168,7 +1168,7 @@ export async function action({ params, request, }: Route.ActionArgs) { - invariant(params.contactId, "Missing contactId param"); + //invariant(params.contactId, "Missing contactId param"); // What is this? const formData = await request.formData(); const updates = Object.fromEntries(formData); await updateContact(params.contactId, updates);