refactor: optimize Dockerfile for improved build process

- Replace ADD with COPY for package.json and pnpm-lock.yaml to enhance clarity.
- Ensure consistent use of corepack commands across stages.
- Add ownership settings for copied files to improve security.
- Change CMD to run the application using 'node server.ts' instead of 'pnpm start'.

Author: brookslybrand

Dockerfile

@@ -9,18 +9,17 @@ FROM base as deps
 
 WORKDIR /remixapp
 
-RUN corepack enable && corepack prepare pnpm@latest --activate
-ADD package.json pnpm-lock.yaml ./
-RUN pnpm install --frozen-lockfile
+COPY package.json pnpm-lock.yaml ./
+RUN corepack enable && pnpm install --frozen-lockfile
 
 # Setup production node_modules
 FROM base as production-deps
 
 WORKDIR /remixapp
 
 COPY --from=deps /remixapp/node_modules /remixapp/node_modules
-ADD package.json pnpm-lock.yaml ./
-RUN corepack enable && corepack prepare pnpm@latest --activate && pnpm prune --prod
+COPY package.json pnpm-lock.yaml ./
+RUN corepack enable && pnpm prune --prod
 
 # Build the app
 FROM base as build
@@ -29,8 +28,8 @@ WORKDIR /remixapp
 
 COPY --from=deps /remixapp/node_modules /remixapp/node_modules
 
-ADD . .
-RUN corepack enable && corepack prepare pnpm@latest --activate && pnpm run build
+COPY . .
+RUN corepack enable && pnpm run build
 
 # Finally, build the production image with minimal footprint
 FROM base
@@ -40,13 +39,14 @@ ENV NODE_ENV="production"
 
 WORKDIR /remixapp
 
-COPY --from=production-deps /remixapp/node_modules /remixapp/node_modules
-COPY --from=build /remixapp/build /remixapp/build
-COPY --from=build /remixapp/server.ts /remixapp/server.ts
-COPY --from=build /remixapp/server /remixapp/server
-COPY --from=build /remixapp/shared /remixapp/shared
-COPY --from=build /remixapp/data /remixapp/data
-COPY --from=build /remixapp/package.json /remixapp/package.json
-COPY --from=build /remixapp/start.sh /remixapp/start.sh
-
-CMD ["pnpm", "start"]
+COPY --chown=node:node --from=production-deps /remixapp/node_modules /remixapp/node_modules
+COPY --chown=node:node --from=build /remixapp/build /remixapp/build
+COPY --chown=node:node --from=build /remixapp/server.ts /remixapp/server.ts
+COPY --chown=node:node --from=build /remixapp/server /remixapp/server
+COPY --chown=node:node --from=build /remixapp/shared /remixapp/shared
+COPY --chown=node:node --from=build /remixapp/data /remixapp/data
+COPY --chown=node:node --from=build /remixapp/package.json /remixapp/package.json
+COPY --chown=node:node --from=build /remixapp/start.sh /remixapp/start.sh
+
+USER node
+CMD ["node", "server.ts"]