Update view-changes script

Author: mjackson

scripts/utils/packages.js

@@ -1,3 +1,4 @@
+import * as fs from 'node:fs';
 import * as path from 'node:path';
 
 const __dirname = path.dirname(new URL(import.meta.url).pathname);
@@ -7,11 +8,24 @@ export const packagesDir = path.relative(
   path.resolve(__dirname, '..', '..', 'packages'),
 );
 
+/** @type () => string[] */
+export function getAllPackageNames() {
+  return fs.readdirSync(packagesDir).filter((name) => {
+    let dir = getPackageDir(name);
+    return fs.existsSync(dir) && fs.statSync(dir).isDirectory();
+  });
+}
+
 /** @type (packageName: string) => string */
 export function getPackageDir(packageName) {
   return path.resolve(packagesDir, packageName);
 }
 
+/** @type (packageName: string) => boolean */
+export function packageExists(packageName) {
+  return fs.existsSync(getPackageDir(packageName));
+}
+
 /** @type (packageName: string, filename: string) => string */
 export function getPackageFile(packageName, filename) {
   return path.join(getPackageDir(packageName), filename);

scripts/view-changes.js

@@ -1,20 +1,5 @@
-import * as fs from 'node:fs';
-
 import { getChanges } from './utils/changes.js';
-import { getPackageDir, packagesDir } from './utils/packages.js';
-
-let packageName = process.argv[2];
-
-/** @type {(packageName: string) => import('./utils/changes.js').Changes | null} */
-function getPackageChanges(packageName) {
-  let changes = getChanges(packageName, 'HEAD');
-
-  if (!changes || !changes.body.trim()) {
-    return null;
-  }
-
-  return changes;
-}
+import { getAllPackageNames, packageExists } from './utils/packages.js';
 
 /** @type {(packageName: string, changes: import('./utils/changes.js').Changes) => void} */
 function printPackageChanges(packageName, changes) {
@@ -24,15 +9,15 @@ function printPackageChanges(packageName, changes) {
   console.log();
 }
 
-if (packageName) {
-  let dir = getPackageDir(packageName);
+let packageName = process.argv[2];
 
-  if (!fs.existsSync(dir)) {
+if (packageName) {
+  if (!packageExists(packageName)) {
     console.error(`Error: Package "${packageName}" not found in ./packages`);
     process.exit(1);
   }
 
-  let changes = getPackageChanges(packageName);
+  let changes = getChanges(packageName, 'HEAD');
 
   if (changes) {
     printPackageChanges(packageName, changes);
@@ -41,18 +26,14 @@ if (packageName) {
     console.log();
   }
 } else {
-  let packages = fs.readdirSync(packagesDir).filter((name) => {
-    let dir = getPackageDir(name);
-    return fs.existsSync(dir) && fs.statSync(dir).isDirectory();
-  });
-
   let hasChanges = false;
 
-  packages.forEach((pkg) => {
-    let changes = getPackageChanges(pkg);
+  let packageNames = getAllPackageNames();
+  packageNames.forEach((packageName) => {
+    let changes = getChanges(packageName, 'HEAD');
     if (changes) {
       hasChanges = true;
-      printPackageChanges(pkg, changes);
+      printPackageChanges(packageName, changes);
     }
   });