You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since esbuild options are not directly exposed, I'd like to propose either setting the keepNamesesbuild option to true or exposing a similar option in remix.config.js.
By exposing an option, remix will still be able to change the underlying build system without exposing esbuild options directly.
The reasoning for this option is to ensure that the dependencies in serverDependenciesToBundle that make use of function and class names will continue to work. I ran into an issue when bundling oidc-provider because class names were removed, causing the library to pass empty strings in places where it expects the class name.
In the mean time, I'm using a work-around similar to the one in this comment
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Since
esbuild
options are not directly exposed, I'd like to propose either setting thekeepNames
esbuild
option totrue
or exposing a similar option inremix.config.js
.By exposing an option,
remix
will still be able to change the underlying build system without exposingesbuild
options directly.The reasoning for this option is to ensure that the dependencies in
serverDependenciesToBundle
that make use of function and class names will continue to work. I ran into an issue when bundling oidc-provider because class names were removed, causing the library to pass empty strings in places where it expects the class name.In the mean time, I'm using a work-around similar to the one in this comment
Beta Was this translation helpful? Give feedback.
All reactions