You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, I love Remix, so thank you and make sure not to lose too much time on this proposal.
I find it slightly peculiar that the default appDirectory name is app and not src:
Most projects I’ve encountered, put their uncompiled source files in a src directory. It is my understanding that the appDirectory folder is equivalent to this folder. In a monorepository, it’s nice if all packages are similarly organised, so using the src convention makes sense from that perspective
Also in a monorepository, it’s common to have both an apps and packages folder, which contain all workspace packages. It’s a bit weird to have e.g. apps/my-remix-app/app or apps/web/app.
Arguably, the “my-remix-app” or “web” folders are the ones that contain the entire app, and the appDirectory is only part of that.
Having uniform folder naming convention in a monorepo helpful for e.g. having an .eslintignore line for /apps/*/src/__generated__
This leads to an adjacent point that perhaps srcDirectory is a better-suited name for appDirectory
Of course, the cost is just a single line in remix.config.js so no real hassle. But I’m proposing it anyway because it seems like a more sensible default for new projects as well.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hello,
First of all, I love Remix, so thank you and make sure not to lose too much time on this proposal.
I find it slightly peculiar that the default
appDirectory
name isapp
and notsrc
:src
directory. It is my understanding that theappDirectory
folder is equivalent to this folder. In a monorepository, it’s nice if all packages are similarly organised, so using thesrc
convention makes sense from that perspectiveapps
andpackages
folder, which contain all workspace packages. It’s a bit weird to have e.g.apps/my-remix-app/app
orapps/web/app
.my-remix-app
” or “web
” folders are the ones that contain the entire app, and theappDirectory
is only part of that..eslintignore
line for/apps/*/src/__generated__
srcDirectory
is a better-suited name forappDirectory
Of course, the cost is just a single line in
remix.config.js
so no real hassle. But I’m proposing it anyway because it seems like a more sensible default for new projects as well.Looking forward to your thoughts!
Beta Was this translation helpful? Give feedback.
All reactions