Vite on Cloudflare - request in getLoadContext?

[aaronadamsCA]

I gave the experimental Cloudflare Vite support a shot. Nice work!

I understand per the docs that it's not meant to be feature-complete yet, specifically that the Cloudflare EventContext will take some time to expose in full (or at least in greater part).

In the meantime, I have two questions:

• Can you improve this type:

  remix/packages/remix-dev/vite/presets/cloudflare.ts

  Lines 3 to 5 in ae88454

  	type GetRemixDevLoadContext = (
  	loadContext: Record<string, unknown>
  	) => Record<string, unknown> | Promise<Record<string, unknown>>;

  To better match this type?

  remix/packages/remix-cloudflare-pages/worker.ts

  Lines 11 to 17 in ae88454

  	export type GetLoadContextFunction<
  	Env = unknown,
  	Params extends string = any,
  	Data extends Record<string, unknown> = Record<string, unknown>
  	> = (
  	context: EventContext<Env, Params, Data>
  	) => Promise<AppLoadContext> | AppLoadContext;

  And also specify how much of EventContext you actually support (so far just { env: unknown }). This would get us a step closer to writing one getLoadContext function signature that is compatible with both of these types.

• Do you need to wait for Wrangler to expose Request, or could you potentially get it from Vite and add it to context? I ask because we need the URL and headers in getLoadContext. I'm not familiar with the Vite plugin API so I have no idea if that's possible.

With these two pieces, we could probably get this up and running with our apps to help shake out any further issues. Looking forward to these improvements!